Promise-based RTCPeerConnection::getStats implementation.

Promise-based RTCPeerConnection::getStats implementation (behind flag).

RTCStatsReport[1] added. It contains code for translating
WebRTCStatsReport and stats types[2] into stats dictionaries[3] by
looping over stats and stats members. JavaScript dictionaries are plain
javascript objects created on the fly.

RTCPeerConnection::getStats invokes the peer connection handler's
getStats and creates the RTCStatsReport in a callback and resolves the
promise.

Test related changes:
- peerconnection_getstats.js: This is a browser test that run the real
  code all the way down to the WebRTC layer (no mocking on any layer).
  It makes sure getStats resolves the promise and returns a non-empty
  set of stats, with simple sanity check on properties that all RTCStats
  dictionaries have in common.
- mock_webrtc_peer_connection_handler.cc: Mock implementation of
  the handler's getStats, returning a stats object containing every type
  of stats member.
- RTCPeerConnection-getStats-promise.html: A layout test that use the
  mock peer connection handler. Verifies the value of each stat member.

[1] https://w3c.github.io/webrtc-pc/#rtcstatsreport-object
[2] https://cs.chromium.org/chromium/src/third_party/WebKit/public/platform/WebRTCStats.h?q=WebRTCStats.h&sq=package:chromium&dr=CSs&l=37
[3] https://w3c.github.io/webrtc-stats/

BUG=chromium:627816
Committed: https://crrev.com/8966cb75fba3830252c4668fe4348b636604f372
Cr-Commit-Position: refs/heads/master@{#421491}

[hbos_chromium, 2016-09-26 08:12:14]

Patchset #3 (id:40001) has been deleted

[hbos_chromium, 2016-09-26 08:12:21]

Patchset #2 (id:20001) has been deleted

[hbos_chromium, 2016-09-26 08:12:28]

Patchset #1 (id:1) has been deleted

[hbos_chromium, 2016-09-26 08:22:22]

The CQ bit was checked by hbos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 08:22:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hbos_chromium, 2016-09-26 08:50:22]

Description was changed from

==========
Promise-based RTCPeerConnection::getStats implementation.

BUG=chromium:627816
==========

to

==========
Promise-based RTCPeerConnection::getStats implementation (behind flag).

RTCStatsReport[1] added. It contains code for translating
WebRTCStatsReport and stats types[2] into stats dictionaries[3] by
looping over stats and stats members. JavaScript dictionaries are plain
javascript objects created on the fly.

RTCPeerConnection::getStats invokes the peer connection handler's
getStats and creates the RTCStatsReport in a callback and resolves the
promise.

Test related changes:
- peerconnection_getstats.js: This is a browser test that run the real
  code all the way down to the WebRTC layer (no mocking on any layer).
  It makes sure getStats resolves the promise and returns a non-empty
  set of stats, with simple sanity check on properties that all RTCStats
  dictionaries have in common.
- mock_webrtc_peer_connection_handler.cc: Mock implementation of
  the handler's getStats, returning a stats object containing every type
  of stats member.
- RTCPeerConnection-getStats-promise.html: A layout test that use the
  mock peer connection handler. Verifies the value of each stat member.

[1] https://w3c.github.io/webrtc-pc/#rtcstatsreport-object
[2]
https://cs.chromium.org/chromium/src/third_party/WebKit/public/platform/WebRT...
[3] https://w3c.github.io/webrtc-stats/

BUG=chromium:627816
==========

[hbos_chromium, 2016-09-26 08:52:46]

hbos@chromium.org changed reviewers:
+ hta@chromium.org, mkwst@chromium.org, phoglund@chromium.org

[hbos_chromium, 2016-09-26 08:52:47]

Please take a look, hta, phoglund and mkwst.
(hta: getStats spec author, phoglund/mkwst: owners)

[phoglund_chromium, 2016-09-26 10:49:19]

lgtm for tests

[hbos_chromium, 2016-09-26 11:23:16]

Please take a look, hta and mkwst.

[hta - Chromium, 2016-09-26 13:21:13]

lgtm

Comments are minor.

https://codereview.chromium.org/2363673002/diff/80001/components/test_runner/...
File components/test_runner/mock_webrtc_peer_connection_handler.cc (right):

https://codereview.chromium.org/2363673002/diff/80001/components/test_runner/...
components/test_runner/mock_webrtc_peer_connection_handler.cc:115: return
WebVector<T>(vec);
I think you can do this in one line with "return WebVector<T>(1, &vec)".

https://codereview.chromium.org/2363673002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/peerconnection/RTCStatsReport.cpp
(right):

https://codereview.chromium.org/2363673002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/peerconnection/RTCStatsReport.cpp:11:
template<typename StringType>
Why template<typename StringType> and not the traditional <typename T>?

[hbos_chromium, 2016-09-26 14:00:16]

Please take a look, mkwst.

https://codereview.chromium.org/2363673002/diff/80001/components/test_runner/...
File components/test_runner/mock_webrtc_peer_connection_handler.cc (right):

https://codereview.chromium.org/2363673002/diff/80001/components/test_runner/...
components/test_runner/mock_webrtc_peer_connection_handler.cc:115: return
WebVector<T>(vec);
On 2016/09/26 13:21:13, hta - Chromium wrote:
> I think you can do this in one line with "return WebVector<T>(1, &vec)".

Done.

https://codereview.chromium.org/2363673002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/peerconnection/RTCStatsReport.cpp
(right):

https://codereview.chromium.org/2363673002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/peerconnection/RTCStatsReport.cpp:11:
template<typename StringType>
On 2016/09/26 13:21:13, hta - Chromium wrote:
> Why template<typename StringType> and not the traditional <typename T>?

Not sure :) Changed to T.

[Mike West, 2016-09-27 08:05:20]

The CQ bit was checked by mkwst@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 08:05:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mike West, 2016-09-27 08:10:47]

Implementation looks reasonable, one question below:

https://codereview.chromium.org/2363673002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/peerconnection/RTCStatsReport.idl
(right):

https://codereview.chromium.org/2363673002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/peerconnection/RTCStatsReport.idl:7: readonly
maplike<DOMString, object>;
Have you sent blink-dev@ an intent to implement this interface?

[hbos_chromium, 2016-09-27 08:38:39]

https://codereview.chromium.org/2363673002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/peerconnection/RTCStatsReport.idl
(right):

https://codereview.chromium.org/2363673002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/peerconnection/RTCStatsReport.idl:7: readonly
maplike<DOMString, object>;
On 2016/09/27 08:10:47, Mike West (OOO until 26th) wrote:
> Have you sent blink-dev@ an intent to implement this interface?

I had forgotten! I sent one out now:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/23ThhTxjVB8

[commit-bot: I haz the power, 2016-09-27 09:16:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 09:16:59]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mike West, 2016-09-28 08:36:07]

LGTM, thanks for sending the intent.

[hbos_chromium, 2016-09-28 08:40:59]

The CQ bit was checked by hbos@chromium.org

[hbos_chromium, 2016-09-28 08:41:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
phoglund@chromium.org, hta@chromium.org
Link to the patchset: https://codereview.chromium.org/2363673002/#ps120001
(title: "Fixed virtual/stable/webexposed/global-interface-listing-expected.txt")

[commit-bot: I haz the power, 2016-09-28 08:41:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 08:50:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 08:50:23]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[hbos_chromium, 2016-09-28 09:01:55]

The CQ bit was checked by hbos@chromium.org

[hbos_chromium, 2016-09-28 09:01:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
phoglund@chromium.org, hta@chromium.org, mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/2363673002/#ps140001
(title: "RTCStatsReport.idl behind getStats-flag instead of updating
virtual/stable/webexposed/global-interf…")

[commit-bot: I haz the power, 2016-09-28 09:02:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 10:33:34]

Description was changed from

==========
Promise-based RTCPeerConnection::getStats implementation (behind flag).

RTCStatsReport[1] added. It contains code for translating
WebRTCStatsReport and stats types[2] into stats dictionaries[3] by
looping over stats and stats members. JavaScript dictionaries are plain
javascript objects created on the fly.

RTCPeerConnection::getStats invokes the peer connection handler's
getStats and creates the RTCStatsReport in a callback and resolves the
promise.

Test related changes:
- peerconnection_getstats.js: This is a browser test that run the real
  code all the way down to the WebRTC layer (no mocking on any layer).
  It makes sure getStats resolves the promise and returns a non-empty
  set of stats, with simple sanity check on properties that all RTCStats
  dictionaries have in common.
- mock_webrtc_peer_connection_handler.cc: Mock implementation of
  the handler's getStats, returning a stats object containing every type
  of stats member.
- RTCPeerConnection-getStats-promise.html: A layout test that use the
  mock peer connection handler. Verifies the value of each stat member.

[1] https://w3c.github.io/webrtc-pc/#rtcstatsreport-object
[2]
https://cs.chromium.org/chromium/src/third_party/WebKit/public/platform/WebRT...
[3] https://w3c.github.io/webrtc-stats/

BUG=chromium:627816
==========

to

==========
Promise-based RTCPeerConnection::getStats implementation (behind flag).

RTCStatsReport[1] added. It contains code for translating
WebRTCStatsReport and stats types[2] into stats dictionaries[3] by
looping over stats and stats members. JavaScript dictionaries are plain
javascript objects created on the fly.

RTCPeerConnection::getStats invokes the peer connection handler's
getStats and creates the RTCStatsReport in a callback and resolves the
promise.

Test related changes:
- peerconnection_getstats.js: This is a browser test that run the real
  code all the way down to the WebRTC layer (no mocking on any layer).
  It makes sure getStats resolves the promise and returns a non-empty
  set of stats, with simple sanity check on properties that all RTCStats
  dictionaries have in common.
- mock_webrtc_peer_connection_handler.cc: Mock implementation of
  the handler's getStats, returning a stats object containing every type
  of stats member.
- RTCPeerConnection-getStats-promise.html: A layout test that use the
  mock peer connection handler. Verifies the value of each stat member.

[1] https://w3c.github.io/webrtc-pc/#rtcstatsreport-object
[2]
https://cs.chromium.org/chromium/src/third_party/WebKit/public/platform/WebRT...
[3] https://w3c.github.io/webrtc-stats/

BUG=chromium:627816
==========

[commit-bot: I haz the power, 2016-09-28 10:33:36]

Committed patchset #5 (id:140001)

[commit-bot: I haz the power, 2016-09-28 10:35:42]

Description was changed from

==========
Promise-based RTCPeerConnection::getStats implementation (behind flag).

RTCStatsReport[1] added. It contains code for translating
WebRTCStatsReport and stats types[2] into stats dictionaries[3] by
looping over stats and stats members. JavaScript dictionaries are plain
javascript objects created on the fly.

RTCPeerConnection::getStats invokes the peer connection handler's
getStats and creates the RTCStatsReport in a callback and resolves the
promise.

Test related changes:
- peerconnection_getstats.js: This is a browser test that run the real
  code all the way down to the WebRTC layer (no mocking on any layer).
  It makes sure getStats resolves the promise and returns a non-empty
  set of stats, with simple sanity check on properties that all RTCStats
  dictionaries have in common.
- mock_webrtc_peer_connection_handler.cc: Mock implementation of
  the handler's getStats, returning a stats object containing every type
  of stats member.
- RTCPeerConnection-getStats-promise.html: A layout test that use the
  mock peer connection handler. Verifies the value of each stat member.

[1] https://w3c.github.io/webrtc-pc/#rtcstatsreport-object
[2]
https://cs.chromium.org/chromium/src/third_party/WebKit/public/platform/WebRT...
[3] https://w3c.github.io/webrtc-stats/

BUG=chromium:627816
==========

to

==========
Promise-based RTCPeerConnection::getStats implementation (behind flag).

RTCStatsReport[1] added. It contains code for translating
WebRTCStatsReport and stats types[2] into stats dictionaries[3] by
looping over stats and stats members. JavaScript dictionaries are plain
javascript objects created on the fly.

RTCPeerConnection::getStats invokes the peer connection handler's
getStats and creates the RTCStatsReport in a callback and resolves the
promise.

Test related changes:
- peerconnection_getstats.js: This is a browser test that run the real
  code all the way down to the WebRTC layer (no mocking on any layer).
  It makes sure getStats resolves the promise and returns a non-empty
  set of stats, with simple sanity check on properties that all RTCStats
  dictionaries have in common.
- mock_webrtc_peer_connection_handler.cc: Mock implementation of
  the handler's getStats, returning a stats object containing every type
  of stats member.
- RTCPeerConnection-getStats-promise.html: A layout test that use the
  mock peer connection handler. Verifies the value of each stat member.

[1] https://w3c.github.io/webrtc-pc/#rtcstatsreport-object
[2]
https://cs.chromium.org/chromium/src/third_party/WebKit/public/platform/WebRT...
[3] https://w3c.github.io/webrtc-stats/

BUG=chromium:627816

Committed: https://crrev.com/8966cb75fba3830252c4668fe4348b636604f372
Cr-Commit-Position: refs/heads/master@{#421491}
==========

[commit-bot: I haz the power, 2016-09-28 10:35:43]

Patchset 5 (id:??) landed as
https://crrev.com/8966cb75fba3830252c4668fe4348b636604f372
Cr-Commit-Position: refs/heads/master@{#421491}