Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1820)

Unified Diff: chrome/browser/media/webrtc/webrtc_browsertest.cc

Issue 2363673002: Promise-based RTCPeerConnection::getStats implementation. (Closed)
Patch Set: RTCStatsReport.idl behind getStats-flag instead of updating virtual/stable/webexposed/global-interf… Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/media/webrtc/webrtc_browsertest_base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/webrtc/webrtc_browsertest.cc
diff --git a/chrome/browser/media/webrtc/webrtc_browsertest.cc b/chrome/browser/media/webrtc/webrtc_browsertest.cc
index f2abe3deb33d7fb371407fe424d5e9a0bfa4fd42..10ead6ad37b999e8fde2b38117f2b83ff0bc9cdf 100644
--- a/chrome/browser/media/webrtc/webrtc_browsertest.cc
+++ b/chrome/browser/media/webrtc/webrtc_browsertest.cc
@@ -49,6 +49,12 @@ class WebRtcBrowserTest : public WebRtcTestBase {
// Flag used by TestWebAudioMediaStream to force garbage collection.
command_line->AppendSwitchASCII(switches::kJavaScriptFlags, "--expose-gc");
+
+ // Flag used by |RunsAudioVideoWebRTCCallInTwoTabsGetStatsPromise|.
+ // TODO(hbos): Remove this when bug crbug.com/627816 is resolved (when this
+ // flag is removed).
+ command_line->AppendSwitchASCII(switches::kEnableBlinkFeatures,
+ "RTCPeerConnectionNewGetStats");
}
void RunsAudioVideoWebRTCCallInTwoTabs(
@@ -198,13 +204,25 @@ IN_PROC_BROWSER_TEST_F(WebRtcBrowserTest,
}
IN_PROC_BROWSER_TEST_F(WebRtcBrowserTest,
- RunsAudioVideoWebRTCCallInTwoTabsGetStats) {
+ RunsAudioVideoWebRTCCallInTwoTabsGetStatsCallback) {
+ StartServerAndOpenTabs();
+ SetupPeerconnectionWithLocalStream(left_tab_);
+ SetupPeerconnectionWithLocalStream(right_tab_);
+ NegotiateCall(left_tab_, right_tab_);
+
+ VerifyStatsGeneratedCallback(left_tab_);
+
+ DetectVideoAndHangUp();
+}
+
+IN_PROC_BROWSER_TEST_F(WebRtcBrowserTest,
+ RunsAudioVideoWebRTCCallInTwoTabsGetStatsPromise) {
StartServerAndOpenTabs();
SetupPeerconnectionWithLocalStream(left_tab_);
SetupPeerconnectionWithLocalStream(right_tab_);
NegotiateCall(left_tab_, right_tab_);
- VerifyStatsGenerated(left_tab_);
+ VerifyStatsGeneratedPromise(left_tab_);
DetectVideoAndHangUp();
}
« no previous file with comments | « no previous file | chrome/browser/media/webrtc/webrtc_browsertest_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698