Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 2363663002: [wasm] Add hash to the crash message of the correctness fuzzer. (Closed)

Created:
4 years, 3 months ago by ahaas
Modified:
4 years, 3 months ago
Reviewers:
mmoroz, titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Add hash to the crash message of the correctness fuzzer. The hash in the crash message is necessary to keep cluster fuzz from grouping all result mismatches. R=titzer@chromium.org, mmoroz@chromium.org Committed: https://crrev.com/78b048c0773380b2cc602a38cce09d68c5ac6274 Cr-Commit-Position: refs/heads/master@{#39625}

Patch Set 1 #

Patch Set 2 : I forgot to cast ints #

Total comments: 1

Patch Set 3 : Use a constant for the seed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M test/fuzzer/wasm-code.cc View 1 2 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
ahaas
4 years, 3 months ago (2016-09-22 09:03:53 UTC) #1
titzer
lgtm https://codereview.chromium.org/2363663002/diff/20001/test/fuzzer/wasm-code.cc File test/fuzzer/wasm-code.cc (right): https://codereview.chromium.org/2363663002/diff/20001/test/fuzzer/wasm-code.cc#newcode102 test/fuzzer/wasm-code.cc:102: data, static_cast<int>(size), 83)); what is 83? the seed? ...
4 years, 3 months ago (2016-09-22 09:54:17 UTC) #10
ahaas
On 2016/09/22 at 09:54:17, titzer wrote: > lgtm > > https://codereview.chromium.org/2363663002/diff/20001/test/fuzzer/wasm-code.cc > File test/fuzzer/wasm-code.cc (right): ...
4 years, 3 months ago (2016-09-22 12:29:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2363663002/40001
4 years, 3 months ago (2016-09-22 12:29:36 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-22 12:54:59 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 12:55:37 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/78b048c0773380b2cc602a38cce09d68c5ac6274
Cr-Commit-Position: refs/heads/master@{#39625}

Powered by Google App Engine
This is Rietveld 408576698