Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: test/fuzzer/wasm-code.cc

Issue 2363663002: [wasm] Add hash to the crash message of the correctness fuzzer. (Closed)
Patch Set: I forgot to cast ints Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 #include <stdint.h> 6 #include <stdint.h>
7 7
8 #include "include/v8.h" 8 #include "include/v8.h"
9 #include "src/isolate.h" 9 #include "src/isolate.h"
10 #include "src/objects.h"
10 #include "src/wasm/encoder.h" 11 #include "src/wasm/encoder.h"
11 #include "src/wasm/wasm-interpreter.h" 12 #include "src/wasm/wasm-interpreter.h"
12 #include "src/wasm/wasm-module.h" 13 #include "src/wasm/wasm-module.h"
13 #include "test/cctest/wasm/test-signatures.h" 14 #include "test/cctest/wasm/test-signatures.h"
14 #include "test/common/wasm/wasm-module-runner.h" 15 #include "test/common/wasm/wasm-module-runner.h"
15 #include "test/fuzzer/fuzzer-support.h" 16 #include "test/fuzzer/fuzzer-support.h"
16 17
17 using namespace v8::internal::wasm; 18 using namespace v8::internal::wasm;
18 19
19 extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) { 20 extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 v8::internal::handle(v8::internal::Smi::FromInt(2), i_isolate), 86 v8::internal::handle(v8::internal::Smi::FromInt(2), i_isolate),
86 v8::internal::handle(v8::internal::Smi::FromInt(3), i_isolate)}; 87 v8::internal::handle(v8::internal::Smi::FromInt(3), i_isolate)};
87 result_compiled = testing::CallWasmFunctionForTesting( 88 result_compiled = testing::CallWasmFunctionForTesting(
88 i_isolate, instance, &compiler_thrower, "main", arraysize(arguments), 89 i_isolate, instance, &compiler_thrower, "main", arraysize(arguments),
89 arguments, v8::internal::wasm::ModuleOrigin::kWasmOrigin); 90 arguments, v8::internal::wasm::ModuleOrigin::kWasmOrigin);
90 } 91 }
91 if (result_interpreted == 0xdeadbeef) { 92 if (result_interpreted == 0xdeadbeef) {
92 CHECK(i_isolate->has_pending_exception()); 93 CHECK(i_isolate->has_pending_exception());
93 i_isolate->clear_pending_exception(); 94 i_isolate->clear_pending_exception();
94 } else { 95 } else {
96 if (result_interpreted != result_compiled) {
97 V8_Fatal(
98 __FILE__, __LINE__,
99 "Interpreter result (%d) != compiled module result (%d). Hash: %u",
100 result_interpreted, result_compiled,
101 v8::internal::StringHasher::HashSequentialString(
102 data, static_cast<int>(size), 83));
titzer 2016/09/22 09:54:17 what is 83? the seed? Maybe add a constant here.
103 }
95 CHECK_EQ(result_interpreted, result_compiled); 104 CHECK_EQ(result_interpreted, result_compiled);
96 } 105 }
97 return 0; 106 return 0;
98 } 107 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698