Cleanup unreachable cert adding code

Cleanup unreachable cert adding code

The ability to use Chrome to import certs directly into the OS was
removed in M49. This cleans up the related code, which is now
unreachable.

Most notably, this removes OnCertAdded/OnCertRemoved from the
CertDatabase, which were intended to relate to direct user additions
of certs, and instead folds the notifications (which only exist
for ChromeOS/Linux when using chrome://certificates) into a generic
OnCertDBChanged, which better reflects the cross-platform knowledge
we have available.

BUG=514767
Committed: https://crrev.com/1778469523cb7726e71898f2bd1362ff49eb973d
Cr-Commit-Position: refs/heads/master@{#424638}

[Ryan Sleevi, 2016-09-22 08:38:13]

The CQ bit was checked by rsleevi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 08:38:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Sleevi, 2016-09-22 08:39:54]

rsleevi@chromium.org changed reviewers:
+ svaldez@chromium.org

[Ryan Sleevi, 2016-09-22 08:39:55]

+cc david because he likes nuking code :)

Steven,

This was a quick, late-night hack that may not be fully complete, but attempts
to expunge a lot of the ancillary code related to the
application/x-x509-user-cert handling. Unsurprisingly, the subtlety is in the
ChromeOS bits, since they ended up tightly coupled in weird ways to that
(especially the private key API), but beyond that, this should be mostly
mechanical.

[Ryan Sleevi, 2016-09-22 08:44:29]

https://codereview.chromium.org/2363653002/diff/1/chrome/browser/chromeos/pla...
File chrome/browser/chromeos/platform_keys/platform_keys_nss.cc (left):

https://codereview.chromium.org/2363653002/diff/1/chrome/browser/chromeos/pla...
chrome/browser/chromeos/platform_keys/platform_keys_nss.cc:638: PK11SlotInfo*
slot =
Lovely persistent memory leak :(

https://codereview.chromium.org/2363653002/diff/1/net/cert/cert_database_mac.cc
File net/cert/cert_database_mac.cc (right):

https://codereview.chromium.org/2363653002/diff/1/net/cert/cert_database_mac....
net/cert/cert_database_mac.cc:132: notifier_.release()->Shutdown();
In the future, cleaning this up would allow eliminating of all of the ctor/dtor
duplication in the per-platform files.

[commit-bot: I haz the power, 2016-09-22 08:53:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 08:53:59]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[Ryan Sleevi, 2016-09-22 08:56:19]

The CQ bit was checked by rsleevi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 08:56:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Sleevi, 2016-09-22 09:00:19]

The CQ bit was checked by rsleevi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 09:00:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 09:15:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 09:15:12]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[svaldez, 2016-09-22 16:50:26]

lgtm, seems reasonable. Though does the Android Certificate Mime Type enum still
need to exist with the cleanup?

https://codereview.chromium.org/2363653002/diff/1/chrome/browser/chromeos/pla...
File chrome/browser/chromeos/platform_keys/platform_keys_nss.cc (right):

https://codereview.chromium.org/2363653002/diff/1/chrome/browser/chromeos/pla...
chrome/browser/chromeos/platform_keys/platform_keys_nss.cc:634:
crypto::ScopedPK11Slot slot =
crypto::ScopedPK11Slot slot(...)?

[Ryan Sleevi, 2016-09-22 18:09:33]

The CQ bit was checked by rsleevi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 18:09:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 18:40:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 18:40:07]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ryan Sleevi, 2016-09-22 19:30:24]

The CQ bit was checked by rsleevi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 19:30:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 20:58:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 20:58:23]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ryan Sleevi, 2016-09-23 20:39:50]

The CQ bit was checked by rsleevi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 20:40:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Sleevi, 2016-09-23 20:49:04]

rsleevi@chromium.org changed reviewers:
+ jam@chromium.org, satorux@chromium.org

[Ryan Sleevi, 2016-09-23 20:49:05]

satorux: chrome/browser/chromeos/platform_keys is probably most
relevant/substantial, but then also all the chromeos/ changes

jam: This changes content/public/browser/content_browser_client's public
interface, but then you can also rubberstamp the
content/components/chrome/android_webview changes which are all mechanical in
nature.

I think this is a reasonable cut-point for the cleanups, but there's still some
low-hanging fruit in CertDatabase and friends for follow-up (e.g. removing the
certificate parameter from OnCertDBChanged, and cleaning up some cross-platform
bits of CertDatabase), but those can be kept just within the //net layer.

[Ryan Sleevi, 2016-09-23 20:59:57]

The CQ bit was checked by rsleevi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 21:00:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 21:18:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 21:18:32]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ryan Sleevi, 2016-09-23 21:31:35]

The CQ bit was checked by rsleevi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 21:32:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 22:53:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 22:53:19]

Dry run: This issue passed the CQ dry run.

[jam, 2016-09-26 15:10:28]

lgtm

[satorux1, 2016-09-30 05:59:40]

satorux@chromium.org changed reviewers:
+ stevenjb@chromium.org

[satorux1, 2016-09-30 05:59:41]

lgtm. +stevenjb@ as fyi

[Ryan Sleevi, 2016-10-11 23:36:28]

The CQ bit was checked by rsleevi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 23:36:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 01:04:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 01:04:53]

Dry run: This issue passed the CQ dry run.

[Ryan Sleevi, 2016-10-12 01:29:38]

The CQ bit was checked by rsleevi@chromium.org

[Ryan Sleevi, 2016-10-12 01:29:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
svaldez@chromium.org, jam@chromium.org, satorux@chromium.org
Link to the patchset: https://codereview.chromium.org/2363653002/#ps180001
(title: "Rebased")

[commit-bot: I haz the power, 2016-10-12 01:29:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 01:36:45]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-10-12 01:40:17]

Description was changed from

==========
Cleanup unreachable cert adding code

The ability to use Chrome to import certs directly into the OS was
removed in M49. This cleans up the related code, which is now
unreachable.

Most notably, this removes OnCertAdded/OnCertRemoved from the
CertDatabase, which were intended to relate to direct user additions
of certs, and instead folds the notifications (which only exist
for ChromeOS/Linux when using chrome://certificates) into a generic
OnCertDBChanged, which better reflects the cross-platform knowledge
we have available.

BUG=514767
==========

to

==========
Cleanup unreachable cert adding code

The ability to use Chrome to import certs directly into the OS was
removed in M49. This cleans up the related code, which is now
unreachable.

Most notably, this removes OnCertAdded/OnCertRemoved from the
CertDatabase, which were intended to relate to direct user additions
of certs, and instead folds the notifications (which only exist
for ChromeOS/Linux when using chrome://certificates) into a generic
OnCertDBChanged, which better reflects the cross-platform knowledge
we have available.

BUG=514767

Committed: https://crrev.com/1778469523cb7726e71898f2bd1362ff49eb973d
Cr-Commit-Position: refs/heads/master@{#424638}
==========

[commit-bot: I haz the power, 2016-10-12 01:40:18]

Patchset 10 (id:??) landed as
https://crrev.com/1778469523cb7726e71898f2bd1362ff49eb973d
Cr-Commit-Position: refs/heads/master@{#424638}