Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: net/socket/client_socket_factory.cc

Issue 2363653002: Cleanup unreachable cert adding code (Closed)
Patch Set: Rebased Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/chromium/quic_stream_factory_test.cc ('k') | net/socket/client_socket_pool_manager_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/client_socket_factory.cc
diff --git a/net/socket/client_socket_factory.cc b/net/socket/client_socket_factory.cc
index 172903ad2ec557baeab809636e502de89eda9ccd..6ea8dc5f110033a8ba4c1f5a32bec83b52417370 100644
--- a/net/socket/client_socket_factory.cc
+++ b/net/socket/client_socket_factory.cc
@@ -33,14 +33,8 @@ class DefaultClientSocketFactory : public ClientSocketFactory,
CertDatabase::GetInstance()->RemoveObserver(this);
}
- void OnCertAdded(const X509Certificate* cert) override {
- ClearSSLSessionCache();
- }
-
- void OnCACertChanged(const X509Certificate* cert) override {
- // Per wtc, we actually only need to flush when trust is reduced.
- // Always flush now because OnCACertChanged does not tell us this.
- // See comments in ClientSocketPoolManager::OnCACertChanged.
+ void OnCertDBChanged(const X509Certificate* cert) override {
+ // Flush sockets whenever CA trust changes.
ClearSSLSessionCache();
}
« no previous file with comments | « net/quic/chromium/quic_stream_factory_test.cc ('k') | net/socket/client_socket_pool_manager_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698