components/offline_pages/background/request_queue_store_sql.h - Issue 2363563002: [Offline pages] Implementation of RQStore.UpdateRequests with StoreUpdateResult

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/background/request_queue_store_sql.h

Issue 2363563002: [Offline pages] Implementation of RQStore.UpdateRequests with StoreUpdateResult (Closed)

Patch Set: Updating test, adding handling for store/transaction failures. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/offline_pages/background/request_queue_store_sql.h

diff --git a/components/offline_pages/background/request_queue_store_sql.h b/components/offline_pages/background/request_queue_store_sql.h

index 647474b342476508995bf0c7f43773e23c254d5f..80ef7223c2990bd70f7e32fa2def20e9a9f19630 100644

--- a/components/offline_pages/background/request_queue_store_sql.h

+++ b/components/offline_pages/background/request_queue_store_sql.h

@@ -36,8 +36,8 @@ class RequestQueueStoreSQL : public RequestQueueStore {

void GetRequests(const GetRequestsCallback& callback) override;

void AddRequest(const SavePageRequest& offline_page,

const AddCallback& callback) override;

- void AddOrUpdateRequest(const SavePageRequest& offline_page,

- const UpdateCallback& callback) override;

+ void UpdateRequests(const std::vector<SavePageRequest>& requests,

+ const UpdateCallback& callback) override;

void RemoveRequests(const std::vector<int64_t>& request_ids,

const RemoveCallback& callback) override;

void ChangeRequestsState(