Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: components/offline_pages/background/request_queue_store.h

Issue 2363563002: [Offline pages] Implementation of RQStore.UpdateRequests with StoreUpdateResult (Closed)
Patch Set: Updating test, adding handling for store/transaction failures. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_queue_store.h
diff --git a/components/offline_pages/background/request_queue_store.h b/components/offline_pages/background/request_queue_store.h
index acf17ed5ef81b268cd6100501df504068fbd03a4..8504c1b1e43e556504f49406f1e54c5c39d94aec 100644
--- a/components/offline_pages/background/request_queue_store.h
+++ b/components/offline_pages/background/request_queue_store.h
@@ -15,6 +15,8 @@
namespace offline_pages {
+typedef StoreUpdateResult<SavePageRequest> UpdateRequestsResult;
+
// Interface for classes storing save page requests.
class RequestQueueStore {
public:
@@ -29,7 +31,8 @@ class RequestQueueStore {
std::vector<std::unique_ptr<SavePageRequest>> /* requests */)>
GetRequestsCallback;
typedef base::Callback<void(ItemActionStatus)> AddCallback;
- typedef base::Callback<void(UpdateStatus)> UpdateCallback;
+ typedef base::Callback<void(std::unique_ptr<UpdateRequestsResult>)>
+ UpdateCallback;
typedef base::Callback<void(
const RequestQueue::UpdateMultipleRequestResults& /* statuses*/,
std::vector<std::unique_ptr<SavePageRequest>> /* requests */)>
@@ -50,10 +53,9 @@ class RequestQueueStore {
virtual void AddRequest(const SavePageRequest& offline_page,
const AddCallback& callback) = 0;
- // Asynchronously adds or updates request in store.
- // Result of the update is passed in the callback.
- virtual void AddOrUpdateRequest(const SavePageRequest& request,
- const UpdateCallback& callback) = 0;
+ // Asynchronously updates requests in store.
+ virtual void UpdateRequests(const std::vector<SavePageRequest>& requests,
+ const UpdateCallback& callback) = 0;
// Asynchronously removes requests from the store using their IDs.
// Result of the update, and a number of removed pages is passed in the

Powered by Google App Engine
This is Rietveld 408576698