chrome/browser/resources/vr_shell/vr_shell_ui.html - Issue 2363553003: VrShell: implement insecure content warning display

Unified Diff: chrome/browser/resources/vr_shell/vr_shell_ui.html

Issue 2363553003: VrShell: implement insecure content warning display (Closed)

Patch Set: Rebase fixups: QuatToAxisAngle API, unused cursor_distance_ Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/vr_shell/vr_shell_ui.html

diff --git a/chrome/browser/resources/vr_shell/vr_shell_ui.html b/chrome/browser/resources/vr_shell/vr_shell_ui.html

index 4cd5ace00c6038e043499b80c96dafd6d48160ae..fb1a08373d4171936ef9b676981938efeede1be7 100644

--- a/chrome/browser/resources/vr_shell/vr_shell_ui.html

+++ b/chrome/browser/resources/vr_shell/vr_shell_ui.html

@@ -17,6 +17,30 @@ found in the LICENSE file.

</head>

<body>

+<div id="webvr-not-secure-permanent" class="webvr-message-box">

+ <div class="webvr-box">

+ <svg class="webvr-not-secure-icon" width="36px" height="36px"

Dan Beam 2016/10/03 18:12:49 can we just use a background-image on #webvr-not-s

klausw 2016/10/03 19:47:31 Would a background image work for RTL compatibilit

+ viewBox="0 0 36 36" version="1.1"

+ xmlns="http://www.w3.org/2000/svg"

+ xmlns:xlink="http://www.w3.org/1999/xlink">

+ <g stroke="none" stroke-width="1" fill="none" fill-rule="evenodd">

+ <path d="M18,0 C8.064,0 0,8.064 0,18 C0,27.936 8.064,36 18,36

+ C27.936,36 36,27.936 36,18 C36,8.064 27.936,0 18,0 L18,0 Z

+ M18,32 C10.2825,32 4,25.7175 4,18 C4,10.2825 10.2825,4 18,4

+ C25.7175,4 32,10.2825 32,18 C32,25.7175 25.7175,32 18,32

+ L18,32 Z M16,27 L20,27 L20,17 L16,17 L16,27 L16,27 Z M16,13

+ L20,13 L20,9 L16,9 L16,13 L16,13 Z" fill="#5A5A5A"></path>

+ </g>

+ </svg>

Dan Beam 2016/10/03 18:12:49 don't embed an svg directly

Dan Beam 2016/10/03 18:12:49 what does this look like? there's likely an exist

klausw 2016/10/03 19:47:31 Moved to ui/webui/resources/images/i_circle.svg, d

klausw 2016/10/03 19:47:31 I didn't find an existing one. It's an "i" with a

+ <div class="webvr-string">$i18n{insecureWebVrContentPermanent}</div>

+ </div>

+</div>

+<div id="webvr-not-secure-transient" class="webvr-message-box">

+ <div>

Dan Beam 2016/10/03 18:12:49 why do you need this outer <div>?

klausw 2016/10/03 19:47:31 This div provides the background and rounded corne

+ <div>$i18n{insecureWebVrContentTransient}</div>

+ </div>

+</div>

</body>