chrome/browser/resources/vr_shell/vr_shell_ui.html - Issue 2363553003: VrShell: implement insecure content warning display

Side by Side Diff: chrome/browser/resources/vr_shell/vr_shell_ui.html

Issue 2363553003: VrShell: implement insecure content warning display (Closed)

Patch Set: Rebase fixups: QuatToAxisAngle API, unused cursor_distance_ Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« chrome/browser/resources/vr_shell/vr_shell_ui.css ('K') | « chrome/browser/resources/vr_shell/vr_shell_ui.css ('k') | chrome/browser/resources/vr_shell/vr_shell_ui.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!--	1 <!--

2 Copyright 2016 The Chromium Authors. All rights reserved.	2 Copyright 2016 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file.	4 found in the LICENSE file.

5 -->	5 -->

6 <!DOCTYPE html>	6 <!DOCTYPE html>

7 <html>	7 <html>

8 <head>	8 <head>

9 <meta charset="utf-8">	9 <meta charset="utf-8">

10 <if expr="is_android or is_ios">	10 <if expr="is_android or is_ios">

11 <meta name="viewport" content="width=device-width, initial-scale=1.0,	11 <meta name="viewport" content="width=device-width, initial-scale=1.0,

12 maximum-scale=1.0, user-scalable=no">	12 maximum-scale=1.0, user-scalable=no">

13 <meta http-equiv="cache-control" content="no-cache">	13 <meta http-equiv="cache-control" content="no-cache">

14 <meta http-equiv="pragma" content="no-cache">	14 <meta http-equiv="pragma" content="no-cache">

15 </if>	15 </if>

16 <title>Vr Shell UIs</title>	16 <title>Vr Shell UIs</title>

17 <link rel="stylesheet" href="vr_shell_ui.css">	17 <link rel="stylesheet" href="vr_shell_ui.css">

18 </head>	18 </head>

19 <body>	19 <body>

	20 <div id="webvr-not-secure-permanent" class="webvr-message-box">

	21 <div class="webvr-box">

	22 <svg class="webvr-not-secure-icon" width="36px" height="36px"
	Dan Beam 2016/10/03 18:12:49 can we just use a background-image on #webvr-not-s can we just use a background-image on #webvr-not-secure-permanent? klausw 2016/10/03 19:47:31 Would a background image work for RTL compatibilit Show quoted text On 2016/10/03 18:12:49, Dan Beam wrote: > can we just use a background-image on #webvr-not-secure-permanent? Would a background image work for RTL compatibility? This way, the inline-block display moves it to the right when shown alongside RTL text, see screenshot in https://bugs.chromium.org/p/chromium/issues/detail?id=644492#c9
	23 viewBox="0 0 36 36" version="1.1"

	24 xmlns="http://www.w3.org/2000/svg"

	25 xmlns:xlink="http://www.w3.org/1999/xlink">

	26 <g stroke="none" stroke-width="1" fill="none" fill-rule="evenodd">

	27 <path d="M18,0 C8.064,0 0,8.064 0,18 C0,27.936 8.064,36 18,36

	28 C27.936,36 36,27.936 36,18 C36,8.064 27.936,0 18,0 L18,0 Z

	29 M18,32 C10.2825,32 4,25.7175 4,18 C4,10.2825 10.2825,4 18,4

	30 C25.7175,4 32,10.2825 32,18 C32,25.7175 25.7175,32 18,32

	31 L18,32 Z M16,27 L20,27 L20,17 L16,17 L16,27 L16,27 Z M16,13

	32 L20,13 L20,9 L16,9 L16,13 L16,13 Z" fill="#5A5A5A"></path>

	33 </g>

	34 </svg>
	Dan Beam 2016/10/03 18:12:49 don't embed an svg directly don't embed an svg directly Dan Beam 2016/10/03 18:12:49 what does this look like? there's likely an exist what does this look like? there's likely an existing .svg that you can re-use klausw 2016/10/03 19:47:31 Moved to ui/webui/resources/images/i_circle.svg, d Show quoted text On 2016/10/03 18:12:49, Dan Beam wrote: > don't embed an svg directly Moved to ui/webui/resources/images/i_circle.svg, does that look appropriate? klausw 2016/10/03 19:47:31 I didn't find an existing one. It's an "i" with a Show quoted text On 2016/10/03 18:12:49, Dan Beam wrote: > what does this look like? there's likely an existing .svg that you can re-use I didn't find an existing one. It's an "i" with a circle around it to indicate an informational message.
	35 <div class="webvr-string">$i18n{insecureWebVrContentPermanent}</div>

	36 </div>

	37 </div>

	38 <div id="webvr-not-secure-transient" class="webvr-message-box">

	39 <div>
	Dan Beam 2016/10/03 18:12:49 why do you need this outer <div>? why do you need this outer <div>? klausw 2016/10/03 19:47:31 This div provides the background and rounded corne Show quoted text On 2016/10/03 18:12:49, Dan Beam wrote: > why do you need this outer <div>? This div provides the background and rounded corners and acts as a container for the text div which is vertically centered within it. Without it, I couldn't get the layout looking right while maintaining the min/max height and spacing.
	40 <div>$i18n{insecureWebVrContentTransient}</div>

	41 </div>

	42 </div>

	43

20 </body>	44 </body>

21	45

22 <!-- Run script after creating body, to let it add its own elements. -->	46 <!-- Run script after creating body, to let it add its own elements. -->

23 <script src="vr_shell_ui.js"></script>	47 <script src="vr_shell_ui.js"></script>

24 </html>	48 </html>

OLD	NEW