Throttle fetches for data reduction proxy config

Throttle fetches for data reduction proxy config
1. Remove the retries on 5xx errors (this is currently set to
5 retries). This affects pingback fetcher also.
2. Change the initial retry interval from 1 second to 30
seconds.
3. Increase the max backoff value to 128 minutes.
4. Change jitter to 0.25.

BUG=649188
Committed: https://crrev.com/6f8273ab21874a191403a9540ae302fbf2f87fb5
Cr-Commit-Position: refs/heads/master@{#420762}

[tbansal1, 2016-09-21 23:43:07]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 23:43:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2016-09-22 00:04:14]

Description was changed from

==========
PS

BUG=
==========

to

==========
Throttle fetches for data reduction proxy config
1. Remove the retries on 5xx errors (this is currently set to 
5 retries).
2. Change the initial retry interval from 1 second to 16 
seconds. 

BUG=649188
==========

[tbansal1, 2016-09-22 00:04:34]

Patchset #1 (id:1) has been deleted

[tbansal1, 2016-09-22 00:04:40]

Patchset #1 (id:20001) has been deleted

[tbansal1, 2016-09-22 00:04:46]

Patchset #1 (id:40001) has been deleted

[tbansal1, 2016-09-22 00:04:54]

Patchset #1 (id:60001) has been deleted

[tbansal1, 2016-09-22 00:05:40]

Description was changed from

==========
Throttle fetches for data reduction proxy config
1. Remove the retries on 5xx errors (this is currently set to 
5 retries).
2. Change the initial retry interval from 1 second to 16 
seconds. 

BUG=649188
==========

to

==========
Throttle fetches for data reduction proxy config
1. Remove the retries on 5xx errors (this is currently set to 
5 retries).
2. Change the initial retry interval from 1 second to 16 
seconds. 
3. Increase the jitter.
4. Increase the max backoff value to 90 minutes (current value
is 30 minutes).

BUG=649188
==========

[tbansal1, 2016-09-22 00:06:12]

Description was changed from

==========
Throttle fetches for data reduction proxy config
1. Remove the retries on 5xx errors (this is currently set to 
5 retries).
2. Change the initial retry interval from 1 second to 16 
seconds. 
3. Increase the jitter.
4. Increase the max backoff value to 90 minutes (current value
is 30 minutes).

BUG=649188
==========

to

==========
Throttle fetches for data reduction proxy config
1. Remove the retries on 5xx errors (this is currently set to 
5 retries). This affects pingback fetcher also.
2. Change the initial retry interval from 1 second to 16 
seconds. 
3. Increase the jitter.
4. Increase the max backoff value to 90 minutes (current value
is 30 minutes).

BUG=649188
==========

[tbansal1, 2016-09-22 00:06:27]

tbansal@chromium.org changed reviewers:
+ bengr@chromium.org

[tbansal1, 2016-09-22 00:06:27]

bengr: ptal. thanks.

[tbansal1, 2016-09-22 00:57:56]

Description was changed from

==========
Throttle fetches for data reduction proxy config
1. Remove the retries on 5xx errors (this is currently set to 
5 retries). This affects pingback fetcher also.
2. Change the initial retry interval from 1 second to 16 
seconds. 
3. Increase the jitter.
4. Increase the max backoff value to 90 minutes (current value
is 30 minutes).

BUG=649188
==========

to

==========
Throttle fetches for data reduction proxy config
1. Remove the retries on 5xx errors (this is currently set to 
5 retries). This affects pingback fetcher also.
2. Change the initial retry interval from 1 second to 4 
seconds. 
3. Increase the jitter.
4. Increase the max backoff value to 90 minutes (current value
is 30 minutes).

BUG=649188
==========

[tbansal1, 2016-09-22 00:58:06]

Patchset #1 (id:80001) has been deleted

[tbansal1, 2016-09-22 00:59:11]

Description was changed from

==========
Throttle fetches for data reduction proxy config
1. Remove the retries on 5xx errors (this is currently set to 
5 retries). This affects pingback fetcher also.
2. Change the initial retry interval from 1 second to 4 
seconds. 
3. Increase the jitter.
4. Increase the max backoff value to 90 minutes (current value
is 30 minutes).

BUG=649188
==========

to

==========
Throttle fetches for data reduction proxy config
1. Remove the retries on 5xx errors (this is currently set to 
5 retries). This affects pingback fetcher also.
2. Change the initial retry interval from 1 second to 4 
seconds. 
3. Increase the max backoff value to 90 minutes (current value
is 30 minutes).

BUG=649188
==========

[tbansal1, 2016-09-22 00:59:38]

Patchset #1 (id:100001) has been deleted

[tbansal1, 2016-09-22 20:05:09]

Patchset #1 (id:120001) has been deleted

[tbansal1, 2016-09-22 20:05:34]

Description was changed from

==========
Throttle fetches for data reduction proxy config
1. Remove the retries on 5xx errors (this is currently set to 
5 retries). This affects pingback fetcher also.
2. Change the initial retry interval from 1 second to 4 
seconds. 
3. Increase the max backoff value to 90 minutes (current value
is 30 minutes).

BUG=649188
==========

to

==========
Throttle fetches for data reduction proxy config
1. Remove the retries on 5xx errors (this is currently set to 
5 retries). This affects pingback fetcher also.
2. Change the initial retry interval from 1 second to 30 
seconds. 
3. Increase the max backoff value to 128 minutes.
4. Change jitter to 0.25.

BUG=649188
==========

[tbansal1, 2016-09-22 21:21:55]

tbansal@chromium.org changed reviewers:
+ jpfeiff@chromium.org

[tbansal1, 2016-09-22 21:21:55]

jpfeiff, bengr: ptal. thanks.

[jpfeiff, 2016-09-22 23:07:10]

lgtm

[bengr, 2016-09-23 20:22:32]

lgtm with nit.

https://codereview.chromium.org/2363523003/diff/140001/components/data_reduct...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc
(right):

https://codereview.chromium.org/2363523003/diff/140001/components/data_reduct...
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc:399:
// Do not retry on 5xx errors since the server may already be overloaded.
Add a sentence that says:
// Spurious 5xx errors are still retried on exponential backoff.

[tbansal1, 2016-09-23 20:46:28]

https://codereview.chromium.org/2363523003/diff/140001/components/data_reduct...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc
(right):

https://codereview.chromium.org/2363523003/diff/140001/components/data_reduct...
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc:399:
// Do not retry on 5xx errors since the server may already be overloaded.
On 2016/09/23 20:22:32, bengr wrote:
> Add a sentence that says:
> // Spurious 5xx errors are still retried on exponential backoff.

Done.

[tbansal1, 2016-09-23 20:47:05]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 20:47:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 21:42:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 21:42:37]

Dry run: This issue passed the CQ dry run.

[tbansal1, 2016-09-23 21:42:53]

The CQ bit was checked by tbansal@chromium.org

[tbansal1, 2016-09-23 21:42:54]

The patchset sent to the CQ was uploaded after l-g-t-m from bengr@chromium.org,
jpfeiff@chromium.org
Link to the patchset: https://codereview.chromium.org/2363523003/#ps160001
(title: "rebased, addressed bengr comments")

[commit-bot: I haz the power, 2016-09-23 21:43:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 22:52:26]

Description was changed from

==========
Throttle fetches for data reduction proxy config
1. Remove the retries on 5xx errors (this is currently set to 
5 retries). This affects pingback fetcher also.
2. Change the initial retry interval from 1 second to 30 
seconds. 
3. Increase the max backoff value to 128 minutes.
4. Change jitter to 0.25.

BUG=649188
==========

to

==========
Throttle fetches for data reduction proxy config
1. Remove the retries on 5xx errors (this is currently set to 
5 retries). This affects pingback fetcher also.
2. Change the initial retry interval from 1 second to 30 
seconds. 
3. Increase the max backoff value to 128 minutes.
4. Change jitter to 0.25.

BUG=649188
==========

[commit-bot: I haz the power, 2016-09-23 22:52:27]

Committed patchset #2 (id:160001)

[commit-bot: I haz the power, 2016-09-23 22:55:18]

Description was changed from

==========
Throttle fetches for data reduction proxy config
1. Remove the retries on 5xx errors (this is currently set to 
5 retries). This affects pingback fetcher also.
2. Change the initial retry interval from 1 second to 30 
seconds. 
3. Increase the max backoff value to 128 minutes.
4. Change jitter to 0.25.

BUG=649188
==========

to

==========
Throttle fetches for data reduction proxy config
1. Remove the retries on 5xx errors (this is currently set to
5 retries). This affects pingback fetcher also.
2. Change the initial retry interval from 1 second to 30
seconds.
3. Increase the max backoff value to 128 minutes.
4. Change jitter to 0.25.

BUG=649188

Committed: https://crrev.com/6f8273ab21874a191403a9540ae302fbf2f87fb5
Cr-Commit-Position: refs/heads/master@{#420762}
==========

[commit-bot: I haz the power, 2016-09-23 22:55:19]

Patchset 2 (id:??) landed as
https://crrev.com/6f8273ab21874a191403a9540ae302fbf2f87fb5
Cr-Commit-Position: refs/heads/master@{#420762}