Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc

Issue 2363523003: Throttle fetches for data reduction proxy config (Closed)
Patch Set: rebased, addressed bengr comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc
index 820370ff0fe360dc20385ab7d4b2faa198b25a6f..93178372cbbac724254e8eca305f993110a23d6a 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc
@@ -145,9 +145,9 @@ void DataReductionProxyPingbackClient::CreateFetcherForDataAndStart() {
current_fetcher_->SetLoadFlags(net::LOAD_BYPASS_PROXY);
current_fetcher_->SetUploadData("application/x-protobuf", serialized_request);
current_fetcher_->SetRequestContext(url_request_context_);
- // Configure max retries to be at most kMaxRetries times for 5xx errors.
+ // |current_fetcher_| should not retry on 5xx errors since the server may
+ // already be overloaded.
static const int kMaxRetries = 5;
- current_fetcher_->SetMaxRetriesOn5xx(kMaxRetries);
current_fetcher_->SetAutomaticallyRetryOnNetworkChanges(kMaxRetries);
current_fetcher_->Start();
}
« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698