Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2363503002: Mojo C++ bindings: Add a SINGLE_INTERFACE_WITH_SYNC_REQUESTS mode for MultiplexRouter. (Closed)

Created:
4 years, 3 months ago by yzshen1
Modified:
4 years, 3 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: Add a SINGLE_INTERFACE_WITH_SYNC_REQUESTS mode for MultiplexRouter. BUG=594244 Committed: https://crrev.com/08249baed901ab910c1dde5cfcfa3a738ba06e49 Cr-Commit-Position: refs/heads/master@{#420204}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : .. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -8 lines) Patch
M mojo/public/cpp/bindings/lib/multiplex_router.h View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/multiplex_router.cc View 1 2 2 chunks +12 lines, -7 lines 0 comments Download
M mojo/public/cpp/bindings/lib/sync_handle_registry.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (10 generated)
yzshen1
Hi, Ken. Would you please take a look? Thanks!
4 years, 3 months ago (2016-09-21 20:54:44 UTC) #6
Ken Rockot(use gerrit already)
lgtm
4 years, 3 months ago (2016-09-21 22:03:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2363503002/40001
4 years, 3 months ago (2016-09-21 23:18:29 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-21 23:48:10 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 00:31:25 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/08249baed901ab910c1dde5cfcfa3a738ba06e49
Cr-Commit-Position: refs/heads/master@{#420204}

Powered by Google App Engine
This is Rietveld 408576698