|
|
Created:
4 years, 3 months ago by yzshen1 Modified:
4 years, 2 months ago Reviewers:
Ken Rockot(use gerrit already) CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMojo C++ bindings: always use MultiplexRouter with InterfacePtr/Binding.
This CL doesn't do the cleanup of removing Router and its usage, so that it is
pretty small and easy to revert if necessary. The cleanup will be in future CLs.
BUG=594244
Committed: https://crrev.com/4f84285faf99679494e9fdb743ffc03f3959b1a3
Committed: https://crrev.com/97c656d57efc212da3a8b45a6a743a1b821daffb
Cr-Original-Commit-Position: refs/heads/master@{#420081}
Cr-Commit-Position: refs/heads/master@{#420375}
Patch Set 1 #Patch Set 2 : . #Patch Set 3 : . #Patch Set 4 : . #
Depends on Patchset: Messages
Total messages: 34 (24 generated)
The CQ bit was checked by yzshen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
yzshen@chromium.org changed reviewers: + rockot@chromium.org
Hi, Ken. Would you please take a look? Thanks!
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by yzshen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by yzshen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yzshen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org Link to the patchset: https://codereview.chromium.org/2349293002/#ps40001 (title: ".")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Mojo C++ bindings: always use MultiplexRouter with InterfacePtr/Binding. This CL doesn't do the cleanup of removing Router and its usage, so that it is pretty small and easy to revert if necessary. The cleanup will be in future CLs. BUG=594244 ========== to ========== Mojo C++ bindings: always use MultiplexRouter with InterfacePtr/Binding. This CL doesn't do the cleanup of removing Router and its usage, so that it is pretty small and easy to revert if necessary. The cleanup will be in future CLs. BUG=594244 Committed: https://crrev.com/4f84285faf99679494e9fdb743ffc03f3959b1a3 Cr-Commit-Position: refs/heads/master@{#420081} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/4f84285faf99679494e9fdb743ffc03f3959b1a3 Cr-Commit-Position: refs/heads/master@{#420081}
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2356323002/ by yzshen@chromium.org. The reason for reverting is: It probably caused browser_tests and unit_tests failures on https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%2....
Message was sent while issue was closed.
On 2016/09/21 18:19:52, yzshen1 wrote: > A revert of this CL (patchset #3 id:40001) has been created in > https://codereview.chromium.org/2356323002/ by mailto:yzshen@chromium.org. > > The reason for reverting is: It probably caused browser_tests and unit_tests > failures on > https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%2.... Failures include: StartupBrowserCreatorTest.ProfilesLaunchedAfterCrash BrowserCloseManagerWithBackgroundModeBrowserTest/BrowserCloseManagerWithBackgroundModeBrowserTest.CloseAllBrowsersWithBackgroundMode/1 WindowAppleScriptTest.InsertAndDeleteTabs BrowserCloseManagerWithBackgroundModeBrowserTest/BrowserCloseManagerWithBackgroundModeBrowserTest.CloseAllBrowsersWithBackgroundMode/0 ProfileListDesktopBrowserTest.SignOut SmartSessionRestoreTest.CorrectLoadingOrder ProcessManagerBrowserTest.FrameClassification SessionRestoreTest.RestoreWebUI SessionRestoreTest.ActiveIndexUpdatedAtInsert RunInBackgroundTest.RunInBackgroundBasicTest and DownloadRequestLimiterTest.DownloadRequestLimiter_RendererInitiated
Message was sent while issue was closed.
Description was changed from ========== Mojo C++ bindings: always use MultiplexRouter with InterfacePtr/Binding. This CL doesn't do the cleanup of removing Router and its usage, so that it is pretty small and easy to revert if necessary. The cleanup will be in future CLs. BUG=594244 Committed: https://crrev.com/4f84285faf99679494e9fdb743ffc03f3959b1a3 Cr-Commit-Position: refs/heads/master@{#420081} ========== to ========== Mojo C++ bindings: always use MultiplexRouter with InterfacePtr/Binding. This CL doesn't do the cleanup of removing Router and its usage, so that it is pretty small and easy to revert if necessary. The cleanup will be in future CLs. BUG=594244 Committed: https://crrev.com/4f84285faf99679494e9fdb743ffc03f3959b1a3 Cr-Commit-Position: refs/heads/master@{#420081} ==========
The CQ bit was checked by yzshen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by yzshen@chromium.org
The CQ bit was checked by yzshen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org Link to the patchset: https://codereview.chromium.org/2349293002/#ps60001 (title: ".")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Mojo C++ bindings: always use MultiplexRouter with InterfacePtr/Binding. This CL doesn't do the cleanup of removing Router and its usage, so that it is pretty small and easy to revert if necessary. The cleanup will be in future CLs. BUG=594244 Committed: https://crrev.com/4f84285faf99679494e9fdb743ffc03f3959b1a3 Cr-Commit-Position: refs/heads/master@{#420081} ========== to ========== Mojo C++ bindings: always use MultiplexRouter with InterfacePtr/Binding. This CL doesn't do the cleanup of removing Router and its usage, so that it is pretty small and easy to revert if necessary. The cleanup will be in future CLs. BUG=594244 Committed: https://crrev.com/4f84285faf99679494e9fdb743ffc03f3959b1a3 Cr-Commit-Position: refs/heads/master@{#420081} ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Mojo C++ bindings: always use MultiplexRouter with InterfacePtr/Binding. This CL doesn't do the cleanup of removing Router and its usage, so that it is pretty small and easy to revert if necessary. The cleanup will be in future CLs. BUG=594244 Committed: https://crrev.com/4f84285faf99679494e9fdb743ffc03f3959b1a3 Cr-Commit-Position: refs/heads/master@{#420081} ========== to ========== Mojo C++ bindings: always use MultiplexRouter with InterfacePtr/Binding. This CL doesn't do the cleanup of removing Router and its usage, so that it is pretty small and easy to revert if necessary. The cleanup will be in future CLs. BUG=594244 Committed: https://crrev.com/4f84285faf99679494e9fdb743ffc03f3959b1a3 Committed: https://crrev.com/97c656d57efc212da3a8b45a6a743a1b821daffb Cr-Original-Commit-Position: refs/heads/master@{#420081} Cr-Commit-Position: refs/heads/master@{#420375} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/97c656d57efc212da3a8b45a6a743a1b821daffb Cr-Commit-Position: refs/heads/master@{#420375} |