Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2349293002: Mojo C++ bindings: always use MultiplexRouter with InterfacePtr/Binding. (Closed)

Created:
4 years, 3 months ago by yzshen1
Modified:
4 years, 2 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: always use MultiplexRouter with InterfacePtr/Binding. This CL doesn't do the cleanup of removing Router and its usage, so that it is pretty small and easy to revert if necessary. The cleanup will be in future CLs. BUG=594244 Committed: https://crrev.com/4f84285faf99679494e9fdb743ffc03f3959b1a3 Committed: https://crrev.com/97c656d57efc212da3a8b45a6a743a1b821daffb Cr-Original-Commit-Position: refs/heads/master@{#420081} Cr-Commit-Position: refs/heads/master@{#420375}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -14 lines) Patch
M mojo/public/cpp/bindings/binding.h View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/public/cpp/bindings/interface_ptr.h View 3 chunks +3 lines, -7 lines 0 comments Download
M mojo/public/cpp/bindings/lib/binding_state.h View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/binding_state.cc View 1 2 3 1 chunk +8 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/lib/interface_ptr_state.h View 1 2 3 1 chunk +7 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 34 (24 generated)
yzshen1
Hi, Ken. Would you please take a look? Thanks!
4 years, 3 months ago (2016-09-19 17:36:34 UTC) #4
Ken Rockot(use gerrit already)
lgtm
4 years, 3 months ago (2016-09-19 17:39:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349293002/40001
4 years, 3 months ago (2016-09-21 16:40:49 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-21 16:47:16 UTC) #19
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/4f84285faf99679494e9fdb743ffc03f3959b1a3 Cr-Commit-Position: refs/heads/master@{#420081}
4 years, 3 months ago (2016-09-21 16:50:54 UTC) #21
yzshen1
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2356323002/ by yzshen@chromium.org. ...
4 years, 3 months ago (2016-09-21 18:19:52 UTC) #22
yzshen1
On 2016/09/21 18:19:52, yzshen1 wrote: > A revert of this CL (patchset #3 id:40001) has ...
4 years, 3 months ago (2016-09-21 18:23:20 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349293002/60001
4 years, 2 months ago (2016-09-22 16:56:30 UTC) #30
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-09-22 17:03:00 UTC) #32
commit-bot: I haz the power
4 years, 2 months ago (2016-09-22 17:04:47 UTC) #34
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/97c656d57efc212da3a8b45a6a743a1b821daffb
Cr-Commit-Position: refs/heads/master@{#420375}

Powered by Google App Engine
This is Rietveld 408576698