Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2363403003: Harmony - fix border for OIB. (Closed)

Created:
4 years, 2 months ago by Evan Stade
Modified:
4 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, groby+bubble_chromium.org, rouslan+bubble_chromium.org, msw+watch_chromium.org, hcarmona+bubble_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Harmony - fix border for OIB. This bug only appears for the certain bubbles because it is only visually apparent when the margins are set to zero. I'm not sure why we're setting this extra background. It's probably my fault. BUG=649355 Committed: https://crrev.com/b8be177f507ce4abbb43fbc537e81f96a2219783 Cr-Commit-Position: refs/heads/master@{#421267}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M ui/views/bubble/bubble_border.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/bubble/bubble_dialog_delegate.cc View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Evan Stade
4 years, 2 months ago (2016-09-26 18:04:36 UTC) #2
sky
LGTM
4 years, 2 months ago (2016-09-26 20:02:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2363403003/1
4 years, 2 months ago (2016-09-26 21:59:01 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/284523)
4 years, 2 months ago (2016-09-26 22:54:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2363403003/1
4 years, 2 months ago (2016-09-27 17:37:01 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 18:09:46 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 18:17:15 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b8be177f507ce4abbb43fbc537e81f96a2219783
Cr-Commit-Position: refs/heads/master@{#421267}

Powered by Google App Engine
This is Rietveld 408576698