Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: ui/views/bubble/bubble_border.cc

Issue 2363403003: Harmony - fix border for OIB. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/views/bubble/bubble_dialog_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/bubble/bubble_border.cc
diff --git a/ui/views/bubble/bubble_border.cc b/ui/views/bubble/bubble_border.cc
index 182a3ffd2a24b9a43c49dabb8092521d2c544e9d..0cc3b3a0cda898cd441b7e09f78871cee1cf6975 100644
--- a/ui/views/bubble/bubble_border.cc
+++ b/ui/views/bubble/bubble_border.cc
@@ -507,7 +507,8 @@ void BubbleBackground::Paint(gfx::Canvas* canvas, views::View* view) const {
gfx::RectF bounds(view->GetLocalBounds());
bounds.Inset(gfx::InsetsF(border_->GetInsets()));
if (UseMd()) {
- // The border is 1px at all scale factors. Leave room for it.
+ // The border is 1px at all scale factors. Leave room for it. It's partially
+ // transparent, so we don't want to draw any background underneath it.
const SkScalar one_pixel = SkFloatToScalar(1 / canvas->image_scale());
bounds.Inset(gfx::InsetsF(one_pixel));
}
« no previous file with comments | « no previous file | ui/views/bubble/bubble_dialog_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698