Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: tools/perf/benchmarks/page_cycler_v2.py

Issue 2363343003: Add loading mobile story set (Closed)
Patch Set: Use PageCyclerStory Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/page_sets/loading_mobile.py » ('j') | tools/perf/page_sets/loading_mobile.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/page_cycler_v2.py
diff --git a/tools/perf/benchmarks/page_cycler_v2.py b/tools/perf/benchmarks/page_cycler_v2.py
index 68b8e27a3cda2dc72fde3be6d4f8336f3f08c104..dd017094bba43a65862ac6c5b817f8a4d3b6ed86 100644
--- a/tools/perf/benchmarks/page_cycler_v2.py
+++ b/tools/perf/benchmarks/page_cycler_v2.py
@@ -215,3 +215,15 @@ class PageCyclerV2BasicOopif(_PageCyclerV2):
def CreateStorySet(self, options):
return page_sets.OopifBasicPageSet(cache_temperatures=[
cache_temperature.PCV1_COLD, cache_temperature.PCV1_WARM])
+
+
+class PageCyclerV2LoadingMobile(_PageCyclerV2):
+ """ A benchmark measuring loading performance of mobile sites. """
+
+ @classmethod
+ def Name(cls):
+ return 'page_cycler_v2.loading_mobile'
nednguyen 2016/09/27 15:36:01 I am not sure if we should keep the page_cycler_v2
kouhei (in TOK) 2016/09/27 22:37:21 sgtm
nednguyen 2016/09/29 13:28:35 Let's move this to tools/perf/benchmarks/loading.p
Kunihiko Sakamoto 2016/09/30 05:17:12 Done. Is it OK that loading.LoadingMobile inherits
+
+ def CreateStorySet(self, options):
+ return page_sets.LoadingMobileStorySet(cache_temperatures=[
+ cache_temperature.PCV1_COLD, cache_temperature.PCV1_WARM])
« no previous file with comments | « no previous file | tools/perf/page_sets/loading_mobile.py » ('j') | tools/perf/page_sets/loading_mobile.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698