Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: tools/perf/benchmarks/page_cycler_v2.py

Issue 2363343003: Add loading mobile story set (Closed)
Patch Set: Use PageCyclerStory Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """The page cycler v2. 5 """The page cycler v2.
6 6
7 For details, see design doc: 7 For details, see design doc:
8 https://docs.google.com/document/d/1EZQX-x3eEphXupiX-Hq7T4Afju5_sIdxPWYetj7ynd0 8 https://docs.google.com/document/d/1EZQX-x3eEphXupiX-Hq7T4Afju5_sIdxPWYetj7ynd0
9 """ 9 """
10 10
(...skipping 197 matching lines...) Expand 10 before | Expand all | Expand 10 after
208 set, without running in out-of-process iframes mode.. """ 208 set, without running in out-of-process iframes mode.. """
209 page_set = page_sets.OopifBasicPageSet 209 page_set = page_sets.OopifBasicPageSet
210 210
211 @classmethod 211 @classmethod
212 def Name(cls): 212 def Name(cls):
213 return 'page_cycler_v2.basic_oopif' 213 return 'page_cycler_v2.basic_oopif'
214 214
215 def CreateStorySet(self, options): 215 def CreateStorySet(self, options):
216 return page_sets.OopifBasicPageSet(cache_temperatures=[ 216 return page_sets.OopifBasicPageSet(cache_temperatures=[
217 cache_temperature.PCV1_COLD, cache_temperature.PCV1_WARM]) 217 cache_temperature.PCV1_COLD, cache_temperature.PCV1_WARM])
218
219
220 class PageCyclerV2LoadingMobile(_PageCyclerV2):
221 """ A benchmark measuring loading performance of mobile sites. """
222
223 @classmethod
224 def Name(cls):
225 return 'page_cycler_v2.loading_mobile'
nednguyen 2016/09/27 15:36:01 I am not sure if we should keep the page_cycler_v2
kouhei (in TOK) 2016/09/27 22:37:21 sgtm
nednguyen 2016/09/29 13:28:35 Let's move this to tools/perf/benchmarks/loading.p
Kunihiko Sakamoto 2016/09/30 05:17:12 Done. Is it OK that loading.LoadingMobile inherits
226
227 def CreateStorySet(self, options):
228 return page_sets.LoadingMobileStorySet(cache_temperatures=[
229 cache_temperature.PCV1_COLD, cache_temperature.PCV1_WARM])
OLDNEW
« no previous file with comments | « no previous file | tools/perf/page_sets/loading_mobile.py » ('j') | tools/perf/page_sets/loading_mobile.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698