Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2363343003:
Add loading mobile story set (Closed)
|
Created:
4 years, 2 months ago by Kunihiko Sakamoto Modified:
4 years, 2 months ago CC:
chromium-reviews, telemetry-reviews_chromium.org, dtu Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd loading mobile story set
This adds a story set and corresponding benchmark for mobile loading
performance loading team is interested in.
Design doc: https://docs.google.com/document/d/1QKlZIoURAxZk-brrXsKYZl9O8ieqXht3ogeF9yLNFCI/edit
BUG=643524
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
Committed: https://crrev.com/31d0a108f1783a04f2b981d668883a43a30ddc32
Cr-Commit-Position: refs/heads/master@{#423993}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Use PageCyclerStory #
Total comments: 6
Patch Set 3 : loading.mobile benchmark #Patch Set 4 : wpr uploaded #
Total comments: 4
Patch Set 5 : Comments addressed #
Total comments: 22
Patch Set 6 : comments addressed and re-recorded #
Messages
Total messages: 42 (15 generated)
Description was changed from ========== [WIP] Add loading_mobile stry set BUG=643524 ========== to ========== [WIP] Add loading_mobile stry set BUG=643524 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Patchset #1 (id:1) has been deleted
kouhei@chromium.org changed reviewers: + kouhei@chromium.org
https://codereview.chromium.org/2363343003/diff/20001/tools/perf/page_sets/lo... File tools/perf/page_sets/loading_mobile.py (right): https://codereview.chromium.org/2363343003/diff/20001/tools/perf/page_sets/lo... tools/perf/page_sets/loading_mobile.py:11: class LoadingMobilePage(page_module.Page): Please use PageCyclerStory
ksakamoto@chromium.org changed reviewers: + nednguyen@google.com
+Ned This isn't ready yet, but would you give a high level look? https://codereview.chromium.org/2363343003/diff/20001/tools/perf/page_sets/lo... File tools/perf/page_sets/loading_mobile.py (right): https://codereview.chromium.org/2363343003/diff/20001/tools/perf/page_sets/lo... tools/perf/page_sets/loading_mobile.py:11: class LoadingMobilePage(page_module.Page): On 2016/09/26 22:09:17, kouhei wrote: > Please use PageCyclerStory Done.
I worried that we don't this may time out on bot. Can you run the benchmark locally with your android to see how long does it take? https://codereview.chromium.org/2363343003/diff/40001/tools/perf/benchmarks/p... File tools/perf/benchmarks/page_cycler_v2.py (right): https://codereview.chromium.org/2363343003/diff/40001/tools/perf/benchmarks/p... tools/perf/benchmarks/page_cycler_v2.py:225: return 'page_cycler_v2.loading_mobile' I am not sure if we should keep the page_cycler_v2 branding. I am thinking about naming this "loading.mobile" to make it clearer for people who are new to our benchmarks system. Wdyt? https://codereview.chromium.org/2363343003/diff/40001/tools/perf/page_sets/lo... File tools/perf/page_sets/loading_mobile.py (right): https://codereview.chromium.org/2363343003/diff/40001/tools/perf/page_sets/lo... tools/perf/page_sets/loading_mobile.py:107: def AddStories(self, label, urls, cache_temperatures): nits: label here should be a set, since we may stories with multiple labels
https://codereview.chromium.org/2363343003/diff/40001/tools/perf/benchmarks/p... File tools/perf/benchmarks/page_cycler_v2.py (right): https://codereview.chromium.org/2363343003/diff/40001/tools/perf/benchmarks/p... tools/perf/benchmarks/page_cycler_v2.py:225: return 'page_cycler_v2.loading_mobile' On 2016/09/27 15:36:01, nednguyen wrote: > I am not sure if we should keep the page_cycler_v2 branding. I am thinking about > naming this "loading.mobile" to make it clearer for people who are new to our > benchmarks system. > > Wdyt? sgtm
On 2016/09/27 22:37:21, kouhei wrote: > https://codereview.chromium.org/2363343003/diff/40001/tools/perf/benchmarks/p... > File tools/perf/benchmarks/page_cycler_v2.py (right): > > https://codereview.chromium.org/2363343003/diff/40001/tools/perf/benchmarks/p... > tools/perf/benchmarks/page_cycler_v2.py:225: return > 'page_cycler_v2.loading_mobile' > On 2016/09/27 15:36:01, nednguyen wrote: > > I am not sure if we should keep the page_cycler_v2 branding. I am thinking > about > > naming this "loading.mobile" to make it clearer for people who are new to our > > benchmarks system. > > > > Wdyt? > > sgtm Actually after syncing up with Dave, timeout shouldn't be a problem for this benchmark. We do have 5-hour long benchmark on the waterfall. If we meet the timeout limit with this benchmark, we can adjust the timeout. :-)
On 2016/09/28 16:39:24, nednguyen wrote: > Actually after syncing up with Dave, timeout shouldn't be a problem for this > benchmark. We do have 5-hour long benchmark on the waterfall. If we meet the > timeout limit with this benchmark, we can adjust the timeout. :-) Cool, thanks! For the record, it took 2h35m to run this benchmark locally on Nexus7 (2013).
https://codereview.chromium.org/2363343003/diff/40001/tools/perf/benchmarks/p... File tools/perf/benchmarks/page_cycler_v2.py (right): https://codereview.chromium.org/2363343003/diff/40001/tools/perf/benchmarks/p... tools/perf/benchmarks/page_cycler_v2.py:225: return 'page_cycler_v2.loading_mobile' On 2016/09/27 22:37:21, kouhei wrote: > On 2016/09/27 15:36:01, nednguyen wrote: > > I am not sure if we should keep the page_cycler_v2 branding. I am thinking > about > > naming this "loading.mobile" to make it clearer for people who are new to our > > benchmarks system. > > > > Wdyt? > > sgtm Let's move this to tools/perf/benchmarks/loading.py and name it "loading.mobile"
https://codereview.chromium.org/2363343003/diff/40001/tools/perf/benchmarks/p... File tools/perf/benchmarks/page_cycler_v2.py (right): https://codereview.chromium.org/2363343003/diff/40001/tools/perf/benchmarks/p... tools/perf/benchmarks/page_cycler_v2.py:225: return 'page_cycler_v2.loading_mobile' On 2016/09/29 13:28:35, nednguyen wrote: > On 2016/09/27 22:37:21, kouhei wrote: > > On 2016/09/27 15:36:01, nednguyen wrote: > > > I am not sure if we should keep the page_cycler_v2 branding. I am thinking > > about > > > naming this "loading.mobile" to make it clearer for people who are new to > our > > > benchmarks system. > > > > > > Wdyt? > > > > sgtm > > Let's move this to tools/perf/benchmarks/loading.py and name it "loading.mobile" Done. Is it OK that loading.LoadingMobile inherits page_cycler_v2.PageCyclerV2? https://codereview.chromium.org/2363343003/diff/40001/tools/perf/page_sets/lo... File tools/perf/page_sets/loading_mobile.py (right): https://codereview.chromium.org/2363343003/diff/40001/tools/perf/page_sets/lo... tools/perf/page_sets/loading_mobile.py:107: def AddStories(self, label, urls, cache_temperatures): On 2016/09/27 15:36:01, nednguyen wrote: > nits: label here should be a set, since we may stories with multiple labels Done.
Description was changed from ========== [WIP] Add loading_mobile stry set BUG=643524 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Add loading mobile story set This adds a story set and corresponding benchmark for mobile loading performance loading team is interested in. Design doc: https://docs.google.com/document/d/1QKlZIoURAxZk-brrXsKYZl9O8ieqXht3ogeF9yLNF... BUG=643524 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
I think this is now ready for review. Ned, does this look OK?
the structure lg2me overall, just a few comments You can start on recording & add WPR archive https://codereview.chromium.org/2363343003/diff/80001/tools/perf/benchmarks/p... File tools/perf/benchmarks/page_cycler_v2.py (right): https://codereview.chromium.org/2363343003/diff/80001/tools/perf/benchmarks/p... tools/perf/benchmarks/page_cycler_v2.py:20: class PageCyclerV2(perf_benchmark.PerfBenchmark): You need to keep the name prefixed with "_", otherwise telemetry benchmark discovery will pick it up as an actual benchmark. For sharing code that create the tracing category, just create a method at file level & call it in CreateTimelineBasedMeasurementOptions(..) https://codereview.chromium.org/2363343003/diff/80001/tools/perf/page_sets/lo... File tools/perf/page_sets/loading_mobile.py (right): https://codereview.chromium.org/2363343003/diff/80001/tools/perf/page_sets/lo... tools/perf/page_sets/loading_mobile.py:24: cache_temperatures = [cache_temperature_module.ANY] How long does it take with the cache temperature in total? I thought last time we discuss, Kouhei says we can ignore the cache temperature for now?
Patchset #5 (id:100001) has been deleted
https://codereview.chromium.org/2363343003/diff/80001/tools/perf/benchmarks/p... File tools/perf/benchmarks/page_cycler_v2.py (right): https://codereview.chromium.org/2363343003/diff/80001/tools/perf/benchmarks/p... tools/perf/benchmarks/page_cycler_v2.py:20: class PageCyclerV2(perf_benchmark.PerfBenchmark): On 2016/09/30 09:46:56, nednguyen wrote: > You need to keep the name prefixed with "_", otherwise telemetry benchmark > discovery will pick it up as an actual benchmark. > > For sharing code that create the tracing category, just create a method at file > level & call it in CreateTimelineBasedMeasurementOptions(..) Done. https://codereview.chromium.org/2363343003/diff/80001/tools/perf/page_sets/lo... File tools/perf/page_sets/loading_mobile.py (right): https://codereview.chromium.org/2363343003/diff/80001/tools/perf/page_sets/lo... tools/perf/page_sets/loading_mobile.py:24: cache_temperatures = [cache_temperature_module.ANY] On 2016/09/30 09:46:56, nednguyen wrote: > How long does it take with the cache temperature in total? I thought last time > we discuss, Kouhei says we can ignore the cache temperature for now? It took 2h35m with the cache temperature control (PCV1_COLD & PCV1_WARM), and 58m without the cache temperature control. Let's start with no cache control.
lgtm Overall most of the pages look great to me. However, few pages have problem as pointed out below. You may want to add some thing in the description to let sheriffs know that they should not revert this CL once you commit it. If there are failures/crashes, disabling only the pages that fail by commenting them out intead https://codereview.chromium.org/2363343003/diff/120001/tools/perf/benchmarks/... File tools/perf/benchmarks/loading.py (right): https://codereview.chromium.org/2363343003/diff/120001/tools/perf/benchmarks/... tools/perf/benchmarks/loading.py:12: class LoadingMobile(perf_benchmark.PerfBenchmark): Enable this benchmark on Android only? https://codereview.chromium.org/2363343003/diff/120001/tools/perf/page_sets/l... File tools/perf/page_sets/loading_mobile.py (right): https://codereview.chromium.org/2363343003/diff/120001/tools/perf/page_sets/l... tools/perf/page_sets/loading_mobile.py:33: 'https://googleblog.blogspot.jp/2016/02/building-safer-web-for-everyone.html', This page had "connection is not private" on my local nexus one. https://codereview.chromium.org/2363343003/diff/120001/tools/perf/page_sets/l... tools/perf/page_sets/loading_mobile.py:41: 'http://news.yahoo.com/were-top-10-most-visited-us-national-parks-105323727.html', the yahoo page's recording look a bit broken :-/ https://codereview.chromium.org/2363343003/diff/120001/tools/perf/page_sets/l... tools/perf/page_sets/loading_mobile.py:46: 'http://m.detik.com/finance/read/2016/02/19/151843/3146351/1034/ekspor-tambang-mentah-mau-dibuka-lagi-kalau-sudah-bangun-smelter-bagaimana', m.detik.com also seems a bit broken https://codereview.chromium.org/2363343003/diff/120001/tools/perf/page_sets/l... tools/perf/page_sets/loading_mobile.py:64: 'https://www.flipkart.com/oricum-black-347-canvas-shoes/p/itmeeydsghphdwh9?pid=SHOEEYDSZ7KFHCFN&lid=LSTSHOEEYDSZ7KFHCFN9FHUEA', flipkart somehow just show a giant blank area in the middle of the page :-/ https://codereview.chromium.org/2363343003/diff/120001/tools/perf/page_sets/l... tools/perf/page_sets/loading_mobile.py:66: 'https://airhorner.com', airhoner shows "this site can't provide a secure connection" https://codereview.chromium.org/2363343003/diff/120001/tools/perf/page_sets/l... tools/perf/page_sets/loading_mobile.py:68: 'https://busrouter.sg', busrouter shows "this site can't provide a secure connection" https://codereview.chromium.org/2363343003/diff/120001/tools/perf/page_sets/l... tools/perf/page_sets/loading_mobile.py:71: 'https://wiki-offline.jakearchibald.com/', wiki-offline shows "this site can't provide a secure connection.." https://codereview.chromium.org/2363343003/diff/120001/tools/perf/page_sets/l... tools/perf/page_sets/loading_mobile.py:77: 'https://flipboard.com/', Should we use a flipboard leaf page instead? THe landing page only shows "welcome to flipboard" which may not be that interesting https://codereview.chromium.org/2363343003/diff/120001/tools/perf/page_sets/l... tools/perf/page_sets/loading_mobile.py:105: 'http://www.dramaq.com.tw', dramaq shows 404 not found https://codereview.chromium.org/2363343003/diff/120001/tools/perf/page_sets/l... tools/perf/page_sets/loading_mobile.py:106: 'http://www.locanto.in', same for locanto https://codereview.chromium.org/2363343003/diff/120001/tools/perf/page_sets/l... tools/perf/page_sets/loading_mobile.py:107: 'http://www.francetvinfo.fr', same here
On 2016/10/03 14:42:23, nednguyen wrote: > lgtm > > Overall most of the pages look great to me. However, few pages have problem as > pointed out below. > > You may want to add some thing in the description to let sheriffs know that they > should not revert this CL once you commit it. If there are failures/crashes, > disabling only the pages that fail by commenting them out intead > > https://codereview.chromium.org/2363343003/diff/120001/tools/perf/benchmarks/... > File tools/perf/benchmarks/loading.py (right): > > https://codereview.chromium.org/2363343003/diff/120001/tools/perf/benchmarks/... > tools/perf/benchmarks/loading.py:12: class > LoadingMobile(perf_benchmark.PerfBenchmark): > Enable this benchmark on Android only? > > https://codereview.chromium.org/2363343003/diff/120001/tools/perf/page_sets/l... > File tools/perf/page_sets/loading_mobile.py (right): > > https://codereview.chromium.org/2363343003/diff/120001/tools/perf/page_sets/l... > tools/perf/page_sets/loading_mobile.py:33: > 'https://googleblog.blogspot.jp/2016/02/building-safer-web-for-everyone.html', > This page had "connection is not private" on my local nexus one. > > https://codereview.chromium.org/2363343003/diff/120001/tools/perf/page_sets/l... > tools/perf/page_sets/loading_mobile.py:41: > 'http://news.yahoo.com/were-top-10-most-visited-us-national-parks-105323727.html', > the yahoo page's recording look a bit broken :-/ > > https://codereview.chromium.org/2363343003/diff/120001/tools/perf/page_sets/l... > tools/perf/page_sets/loading_mobile.py:46: > 'http://m.detik.com/finance/read/2016/02/19/151843/3146351/1034/ekspor-tambang-mentah-mau-dibuka-lagi-kalau-sudah-bangun-smelter-bagaimana', > http://m.detik.com also seems a bit broken > > https://codereview.chromium.org/2363343003/diff/120001/tools/perf/page_sets/l... > tools/perf/page_sets/loading_mobile.py:64: > 'https://www.flipkart.com/oricum-black-347-canvas-shoes/p/itmeeydsghphdwh9?pid=SHOEEYDSZ7KFHCFN&lid=LSTSHOEEYDSZ7KFHCFN9FHUEA', > flipkart somehow just show a giant blank area in the middle of the page :-/ > > https://codereview.chromium.org/2363343003/diff/120001/tools/perf/page_sets/l... > tools/perf/page_sets/loading_mobile.py:66: 'https://airhorner.com', > airhoner shows "this site can't provide a secure connection" > > https://codereview.chromium.org/2363343003/diff/120001/tools/perf/page_sets/l... > tools/perf/page_sets/loading_mobile.py:68: 'https://busrouter.sg', > busrouter shows "this site can't provide a secure connection" > > https://codereview.chromium.org/2363343003/diff/120001/tools/perf/page_sets/l... > tools/perf/page_sets/loading_mobile.py:71: > 'https://wiki-offline.jakearchibald.com/', > wiki-offline shows "this site can't provide a secure connection.." > > https://codereview.chromium.org/2363343003/diff/120001/tools/perf/page_sets/l... > tools/perf/page_sets/loading_mobile.py:77: 'https://flipboard.com/', > Should we use a flipboard leaf page instead? THe landing page only shows > "welcome to flipboard" which may not be that interesting > > https://codereview.chromium.org/2363343003/diff/120001/tools/perf/page_sets/l... > tools/perf/page_sets/loading_mobile.py:105: 'http://www.dramaq.com.tw', > dramaq shows 404 not found > > https://codereview.chromium.org/2363343003/diff/120001/tools/perf/page_sets/l... > tools/perf/page_sets/loading_mobile.py:106: 'http://www.locanto.in', > same for locanto > > https://codereview.chromium.org/2363343003/diff/120001/tools/perf/page_sets/l... > tools/perf/page_sets/loading_mobile.py:107: 'http://www.francetvinfo.fr', > same here Also can you edit tools/perf/OWNERS to say that kouhei@ is also a good reviewer for the loading benchmarks?
Sorry for the problems in the recording. I should have examined it closely. I think one reason for the broken-looking pages is that I recorded them on desktop Chrome. Tomorrow I will try re-recording them using an Android.
On 2016/10/04 09:51:08, Kunihiko Sakamoto wrote: > Sorry for the problems in the recording. I should have examined it closely. > > I think one reason for the broken-looking pages is that I recorded them on > desktop Chrome. Tomorrow I will try re-recording them using an Android. Feel free to disable the pages that have problems & add them in subsequent patch.
kouhei@, is this OK with you? On 2016/10/03 14:43:23, nednguyen wrote: > Also can you edit tools/perf/OWNERS to say that kouhei@ is also a good reviewer > for the loading benchmarks? Done. https://codereview.chromium.org/2363343003/diff/120001/tools/perf/benchmarks/... File tools/perf/benchmarks/loading.py (right): https://codereview.chromium.org/2363343003/diff/120001/tools/perf/benchmarks/... tools/perf/benchmarks/loading.py:12: class LoadingMobile(perf_benchmark.PerfBenchmark): On 2016/10/03 14:42:22, nednguyen wrote: > Enable this benchmark on Android only? Done. https://codereview.chromium.org/2363343003/diff/120001/tools/perf/page_sets/l... File tools/perf/page_sets/loading_mobile.py (right): https://codereview.chromium.org/2363343003/diff/120001/tools/perf/page_sets/l... tools/perf/page_sets/loading_mobile.py:33: 'https://googleblog.blogspot.jp/2016/02/building-safer-web-for-everyone.html', On 2016/10/03 14:42:22, nednguyen wrote: > This page had "connection is not private" on my local nexus one. I couldn't resolve this :-( Filed crbug.com/653775. https://codereview.chromium.org/2363343003/diff/120001/tools/perf/page_sets/l... tools/perf/page_sets/loading_mobile.py:41: 'http://news.yahoo.com/were-top-10-most-visited-us-national-parks-105323727.html', On 2016/10/03 14:42:23, nednguyen wrote: > the yahoo page's recording look a bit broken :-/ Re-recorded. https://codereview.chromium.org/2363343003/diff/120001/tools/perf/page_sets/l... tools/perf/page_sets/loading_mobile.py:46: 'http://m.detik.com/finance/read/2016/02/19/151843/3146351/1034/ekspor-tambang-mentah-mau-dibuka-lagi-kalau-sudah-bangun-smelter-bagaimana', On 2016/10/03 14:42:23, nednguyen wrote: > http://m.detik.com also seems a bit broken This was because some stylesheets were blocked by ERR_INSECURE_RESPONSE. Disabled for now. https://codereview.chromium.org/2363343003/diff/120001/tools/perf/page_sets/l... tools/perf/page_sets/loading_mobile.py:64: 'https://www.flipkart.com/oricum-black-347-canvas-shoes/p/itmeeydsghphdwh9?pid=SHOEEYDSZ7KFHCFN&lid=LSTSHOEEYDSZ7KFHCFN9FHUEA', On 2016/10/03 14:42:22, nednguyen wrote: > flipkart somehow just show a giant blank area in the middle of the page :-/ The item was no longer available, changed to another one. https://codereview.chromium.org/2363343003/diff/120001/tools/perf/page_sets/l... tools/perf/page_sets/loading_mobile.py:66: 'https://airhorner.com', On 2016/10/03 14:42:22, nednguyen wrote: > airhoner shows "this site can't provide a secure connection" Disabled for now. https://codereview.chromium.org/2363343003/diff/120001/tools/perf/page_sets/l... tools/perf/page_sets/loading_mobile.py:68: 'https://busrouter.sg', On 2016/10/03 14:42:23, nednguyen wrote: > busrouter shows "this site can't provide a secure connection" Disabled for now. https://codereview.chromium.org/2363343003/diff/120001/tools/perf/page_sets/l... tools/perf/page_sets/loading_mobile.py:71: 'https://wiki-offline.jakearchibald.com/', On 2016/10/03 14:42:22, nednguyen wrote: > wiki-offline shows "this site can't provide a secure connection.." Disabled for now. https://codereview.chromium.org/2363343003/diff/120001/tools/perf/page_sets/l... tools/perf/page_sets/loading_mobile.py:77: 'https://flipboard.com/', On 2016/10/03 14:42:22, nednguyen wrote: > Should we use a flipboard leaf page instead? THe landing page only shows > "welcome to flipboard" which may not be that interesting Changed to use a topic page. https://codereview.chromium.org/2363343003/diff/120001/tools/perf/page_sets/l... tools/perf/page_sets/loading_mobile.py:105: 'http://www.dramaq.com.tw', On 2016/10/03 14:42:22, nednguyen wrote: > dramaq shows 404 not found After re-recording on Android, these look good.
lgtm!
The CQ bit was checked by ksakamoto@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com Link to the patchset: https://codereview.chromium.org/2363343003/#ps140001 (title: "comments addressed and re-recorded")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Exceeded global retry quota
On 2016/10/07 14:50:16, commit-bot: I haz the power wrote: > Exceeded global retry quota "android_s5_perf_cq" can be very flaky. Since loading.mobile.reference is passing in https://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf..., I removed "master.tryserver.chromium.perf:android_s5_perf_cq" from CQ_INCLUDE_TRYBOTS so we can land this CL.
Description was changed from ========== Add loading mobile story set This adds a story set and corresponding benchmark for mobile loading performance loading team is interested in. Design doc: https://docs.google.com/document/d/1QKlZIoURAxZk-brrXsKYZl9O8ieqXht3ogeF9yLNF... BUG=643524 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Add loading mobile story set This adds a story set and corresponding benchmark for mobile loading performance loading team is interested in. Design doc: https://docs.google.com/document/d/1QKlZIoURAxZk-brrXsKYZl9O8ieqXht3ogeF9yLNF... BUG=643524 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add loading mobile story set This adds a story set and corresponding benchmark for mobile loading performance loading team is interested in. Design doc: https://docs.google.com/document/d/1QKlZIoURAxZk-brrXsKYZl9O8ieqXht3ogeF9yLNF... BUG=643524 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Add loading mobile story set This adds a story set and corresponding benchmark for mobile loading performance loading team is interested in. Design doc: https://docs.google.com/document/d/1QKlZIoURAxZk-brrXsKYZl9O8ieqXht3ogeF9yLNF... BUG=643524 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Message was sent while issue was closed.
Committed patchset #6 (id:140001)
Message was sent while issue was closed.
Description was changed from ========== Add loading mobile story set This adds a story set and corresponding benchmark for mobile loading performance loading team is interested in. Design doc: https://docs.google.com/document/d/1QKlZIoURAxZk-brrXsKYZl9O8ieqXht3ogeF9yLNF... BUG=643524 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Add loading mobile story set This adds a story set and corresponding benchmark for mobile loading performance loading team is interested in. Design doc: https://docs.google.com/document/d/1QKlZIoURAxZk-brrXsKYZl9O8ieqXht3ogeF9yLNF... BUG=643524 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/31d0a108f1783a04f2b981d668883a43a30ddc32 Cr-Commit-Position: refs/heads/master@{#423993} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/31d0a108f1783a04f2b981d668883a43a30ddc32 Cr-Commit-Position: refs/heads/master@{#423993}
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:140001) has been created in https://codereview.chromium.org/2409433002/ by zhenw@chromium.org. The reason for reverting is: Failure on Android Perf bot BUG=chromium:654215. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
