Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 2363343002: Ported pixel_test to new gpu_integration_test harness. (Closed)

Created:
4 years, 2 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 2 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, eyaich1, nednguyen, xidachen, xlai (Olivia)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ported pixel_test to new gpu_integration_test harness. Ported cloud_storage_test_base as cloud_storage_integration_test_base. Ported pixel tests' page set into pixel_test_pages.py. Eliminated the use of separate JSON files for manually-specified expected colors. The browser is restarted between pixel test pages which require different browser command line arguments. The new harness's test name sorting increases the number of restarts, and therefore the execution time, compared to the old harness. This will be fixed in a follow-on CL. Deleted the old pixel.py harness to avoid confusion. BUG=352807 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/def2386f8a09d45f74207b2b47a070c527cff3bf Cr-Commit-Position: refs/heads/master@{#421951}

Patch Set 1 #

Patch Set 2 : Ported latest tests. Fixed logic bug. Deleted old harness. #

Patch Set 3 : Update revision for OffscreenCanvasWebGLGreenBox. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+980 lines, -322 lines) Patch
M content/test/gpu/generate_buildbot_json.py View 2 chunks +24 lines, -24 lines 0 comments Download
A content/test/gpu/gpu_tests/cloud_storage_integration_test_base.py View 1 chunk +362 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/gpu_integration_test.py View 1 2 chunks +13 lines, -8 lines 0 comments Download
D content/test/gpu/gpu_tests/pixel.py View 1 1 chunk +0 lines, -191 lines 0 comments Download
M content/test/gpu/gpu_tests/pixel_expectations.py View 1 1 chunk +9 lines, -9 lines 0 comments Download
A content/test/gpu/gpu_tests/pixel_integration_test.py View 1 1 chunk +238 lines, -0 lines 0 comments Download
A content/test/gpu/gpu_tests/pixel_test_pages.py View 1 2 1 chunk +244 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.gpu.json View 8 chunks +16 lines, -16 lines 0 comments Download
M testing/buildbot/chromium.gpu.fyi.json View 37 chunks +74 lines, -74 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
Ken Russell (switch to Gerrit)
Mo: let's do an in-person review of this port tomorrow. It's basically boilerplate. Until the ...
4 years, 2 months ago (2016-09-29 04:43:02 UTC) #4
Zhenyao Mo
On 2016/09/29 04:43:02, Ken Russell wrote: > Mo: let's do an in-person review of this ...
4 years, 2 months ago (2016-09-29 22:09:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2363343002/40001
4 years, 2 months ago (2016-09-29 22:12:18 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-29 22:19:45 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 22:22:19 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/def2386f8a09d45f74207b2b47a070c527cff3bf
Cr-Commit-Position: refs/heads/master@{#421951}

Powered by Google App Engine
This is Rietveld 408576698