Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2363333002: Subzero, MIPS32: Add missing functions for genTargetHelperCallFor (Closed)

Created:
4 years, 2 months ago by obucinac
Modified:
4 years, 2 months ago
CC:
native-client-reviews_googlegroups.com, rich.fuhler_imgtec.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero, MIPS32: Filling missing bits from genTargetHelperCallFor Implements missing calls to runtime libraries, covering mostly data casting. R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=4c49b108f7d568c549646f2ede010ab57d41275f

Patch Set 1 #

Patch Set 2 : Add missing functions for genTargetHelperCallFor and some casts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -44 lines) Patch
M src/IceInstMIPS32.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M src/IceInstMIPS32.cpp View 1 1 chunk +11 lines, -0 lines 0 comments Download
M src/IceTargetLoweringMIPS32.cpp View 1 3 chunks +76 lines, -43 lines 0 comments Download
M tests_lit/llvm2ice_tests/fp.convert.ll View 1 38 chunks +156 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
obucinac
Do not commit, WIP!
4 years, 2 months ago (2016-09-26 00:28:22 UTC) #3
obucinac
Ready for review...
4 years, 2 months ago (2016-09-26 16:51:16 UTC) #4
Jim Stichnoth
lgtm
4 years, 2 months ago (2016-09-27 03:12:09 UTC) #5
Jim Stichnoth
4 years, 2 months ago (2016-09-27 03:12:20 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4c49b108f7d568c549646f2ede010ab57d41275f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698