Issue 2363323002: Merge "Fix pattern attribute handling for invalid regular expressions." to M54 branch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2363323002: Merge "Fix pattern attribute handling for invalid regular expressions." to M54 branch (Closed)

Created:
4 years, 2 months ago by tkent

Modified:
4 years, 2 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

Merge "Fix pattern attribute handling for invalid regular expressions." to M54 branch If BaseTextInputType::patternMismatch() was called twice, the second call skipped ScriptRegexp::isValid() check. BUG=639324 Review-Url: https://codereview.chromium.org/2366803002 Cr-Commit-Position: refs/heads/master@{#420604} (cherry picked from commit e7357db8054bca102ee953509b8264cdcd4f2e07) Committed: https://chromium.googlesource.com/chromium/src/+/698789f055c015f6b2b9cc7e3ba92ffffc50eee2

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -0 lines)			Patch
M	third_party/WebKit/LayoutTests/fast/forms/ValidityState-patternMismatch.html	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/fast/forms/ValidityState-patternMismatch-expected.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/html/forms/BaseTextInputType.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

tkent

4 years, 2 months ago (2016-09-26 00:29:35 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
698789f055c015f6b2b9cc7e3ba92ffffc50eee2.