Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2366803002: Fix pattern attribute handling for invalid regular expressions. (Closed)

Created:
4 years, 3 months ago by tkent
Modified:
4 years, 3 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix pattern attribute handling for invalid regular expressions. If BaseTextInputType::patternMismatch() was called twice, the second call skipped ScriptRegexp::isValid() check. BUG=639324 Committed: https://crrev.com/e7357db8054bca102ee953509b8264cdcd4f2e07 Cr-Commit-Position: refs/heads/master@{#420604}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/fast/forms/ValidityState-patternMismatch.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/ValidityState-patternMismatch-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/BaseTextInputType.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
tkent
keishi, would you review this please?
4 years, 3 months ago (2016-09-23 00:43:08 UTC) #3
keishi
LGTM
4 years, 3 months ago (2016-09-23 07:19:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366803002/1
4 years, 3 months ago (2016-09-23 07:25:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 11:41:20 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 11:43:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e7357db8054bca102ee953509b8264cdcd4f2e07
Cr-Commit-Position: refs/heads/master@{#420604}

Powered by Google App Engine
This is Rietveld 408576698