Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1668)

Unified Diff: chrome/browser/chromeos/arc/arc_external_protocol_dialog.cc

Issue 2363303003: Allow the external protocol dialog to handle FORM_SUBMIT navigation (Closed)
Patch Set: address comment Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/arc/arc_navigation_throttle.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/arc/arc_external_protocol_dialog.cc
diff --git a/chrome/browser/chromeos/arc/arc_external_protocol_dialog.cc b/chrome/browser/chromeos/arc/arc_external_protocol_dialog.cc
index 59a5c1b0a39c09a7e76831874522c2437076714e..915ea48da71f8cd3998d657781fe0193ec0e8462 100644
--- a/chrome/browser/chromeos/arc/arc_external_protocol_dialog.cc
+++ b/chrome/browser/chromeos/arc/arc_external_protocol_dialog.cc
@@ -166,7 +166,9 @@ bool RunArcExternalProtocolDialog(const GURL& url,
int routing_id,
ui::PageTransition page_transition,
bool has_user_gesture) {
- if (ShouldIgnoreNavigation(page_transition))
+ // Try to forward <form> submissions to ARC when possible.
+ constexpr bool kAllowFormSubmit = true;
+ if (ShouldIgnoreNavigation(page_transition, kAllowFormSubmit))
return false;
mojom::IntentHelperInstance* intent_helper = GetIntentHelper();
« no previous file with comments | « no previous file | chrome/browser/chromeos/arc/arc_navigation_throttle.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698