Migrate Linux Blimp client to use BlimpClientContext

blimp/client/support/session/blimp_default_identity_provider.cc

Index: blimp/client/support/session/blimp_default_identity_provider.cc
diff --git a/blimp/client/support/session/blimp_default_identity_provider.cc b/blimp/client/support/session/blimp_default_identity_provider.cc
new file mode 100644
index 0000000000000000000000000000000000000000..b2db98af761dba88828b9f6a9d4623193e5324ec
--- /dev/null
+++ b/blimp/client/support/session/blimp_default_identity_provider.cc
@@ -0,0 +1,37 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "blimp/client/support/session/blimp_default_identity_provider.h"
+
+#include "google_apis/gaia/oauth2_token_service.h"
+
+namespace blimp {
+namespace {

[David Trainor- moved to gerrit, 2016/09/26 20:54:26]

I'd put this inside the client{} namespace also (or outside both).  Just easier
to read.

[steimel, 2016/09/27 17:35:01]

Done.

+constexpr char kDummyAccountId[] = "";

[David Trainor- moved to gerrit, 2016/09/26 20:54:26]

Should we give this a value?  Is "" anything special (not sure, just curious!)?

[steimel, 2016/09/27 17:35:01]

"" is nothing special. This isn't ever looked at as long as you're using
command-line switches to connect (and as long as we're using a null token
service, I believe you need to use command-line switches). I can throw a random
string in there if you'd like

[David Trainor- moved to gerrit, 2016/09/27 17:40:37]

I think this is fine as long as the IdentityProvider base class doesn't use ""
for anything special/error checking.  But you're right this class won't really
do anything anyway.  I trust your judgement on this :).

[steimel, 2016/09/27 18:26:11]

Looks like IdentitySource uses a check to see if an account id is empty, so I've
added an actual string in there

+}  // namespace
+
+namespace client {
+
+BlimpDefaultIdentityProvider::BlimpDefaultIdentityProvider() {}
+
+BlimpDefaultIdentityProvider::~BlimpDefaultIdentityProvider() {}

[David Trainor- moved to gerrit, 2016/09/26 20:54:26]

= default.  Same for constructor if C++ allows it :).

[steimel, 2016/09/27 17:35:01]

Done.

+
+std::string BlimpDefaultIdentityProvider::GetActiveUsername() {
+  return kDummyAccountId;
+}
+
+std::string BlimpDefaultIdentityProvider::GetActiveAccountId() {
+  return kDummyAccountId;
+}
+
+OAuth2TokenService* BlimpDefaultIdentityProvider::GetTokenService() {
+  return nullptr;
+}
+
+bool BlimpDefaultIdentityProvider::RequestLogin() {
+  return false;
+}
+
+}  // namespace client
+}  // namespace blimp