Chromium Code Reviews| OLD | NEW |
|---|---|
| (Empty) | |
| 1 // Copyright 2016 The Chromium Authors. All rights reserved. | |
| 2 // Use of this source code is governed by a BSD-style license that can be | |
| 3 // found in the LICENSE file. | |
| 4 | |
| 5 #include "blimp/client/support/session/blimp_default_identity_provider.h" | |
| 6 | |
| 7 #include "google_apis/gaia/oauth2_token_service.h" | |
| 8 | |
| 9 namespace blimp { | |
| 10 namespace { | |
|
David Trainor- moved to gerrit
2016/09/26 20:54:26
I'd put this inside the client{} namespace also (o
steimel
2016/09/27 17:35:01
Done.
| |
| 11 constexpr char kDummyAccountId[] = ""; | |
|
David Trainor- moved to gerrit
2016/09/26 20:54:26
Should we give this a value? Is "" anything speci
steimel
2016/09/27 17:35:01
"" is nothing special. This isn't ever looked at a
David Trainor- moved to gerrit
2016/09/27 17:40:37
I think this is fine as long as the IdentityProvid
steimel
2016/09/27 18:26:11
Looks like IdentitySource uses a check to see if a
| |
| 12 } // namespace | |
| 13 | |
| 14 namespace client { | |
| 15 | |
| 16 BlimpDefaultIdentityProvider::BlimpDefaultIdentityProvider() {} | |
| 17 | |
| 18 BlimpDefaultIdentityProvider::~BlimpDefaultIdentityProvider() {} | |
|
David Trainor- moved to gerrit
2016/09/26 20:54:26
= default. Same for constructor if C++ allows it
steimel
2016/09/27 17:35:01
Done.
| |
| 19 | |
| 20 std::string BlimpDefaultIdentityProvider::GetActiveUsername() { | |
| 21 return kDummyAccountId; | |
| 22 } | |
| 23 | |
| 24 std::string BlimpDefaultIdentityProvider::GetActiveAccountId() { | |
| 25 return kDummyAccountId; | |
| 26 } | |
| 27 | |
| 28 OAuth2TokenService* BlimpDefaultIdentityProvider::GetTokenService() { | |
| 29 return nullptr; | |
| 30 } | |
| 31 | |
| 32 bool BlimpDefaultIdentityProvider::RequestLogin() { | |
| 33 return false; | |
| 34 } | |
| 35 | |
| 36 } // namespace client | |
| 37 } // namespace blimp | |
| OLD | NEW |