tools/testing/dart/test_runner.dart - Issue 236313005: Avoid exceptions when analyzing truncated test output.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/test_runner.dart

Issue 236313005: Avoid exceptions when analyzing truncated test output. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/testing/dart/test_runner.dart

diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart

index a3d59b9b560e4b082dacf3237ef39a2d5ce17c8e..994c048aefa9ed8188a9d170f2c70a3fadf7c477 100644

--- a/tools/testing/dart/test_runner.dart

+++ b/tools/testing/dart/test_runner.dart

@@ -1464,7 +1464,7 @@ class AnalysisCommandOutputImpl extends CommandOutputImpl {

if (line.length == 0) continue;

List<String> fields = splitMachineError(line);

// We only consider errors/warnings for files of interest.

- if (fields.length > FILENAME) {

+ if (fields.length > FORMATTED_ERROR) {

if (fields[ERROR_LEVEL] == 'ERROR') {

outErrors.add(fields[FORMATTED_ERROR]);

} else if (fields[ERROR_LEVEL] == 'WARNING') {

« no previous file with comments | « no previous file | no next file » | no next file with comments »