Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: tools/testing/dart/test_runner.dart

Issue 236313005: Avoid exceptions when analyzing truncated test output. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for executing tests. 6 * Classes and methods for executing tests.
7 * 7 *
8 * This module includes: 8 * This module includes:
9 * - Managing parallel execution of tests, including timeout checks. 9 * - Managing parallel execution of tests, including timeout checks.
10 * - Evaluating the output of each test as pass/fail/crash/timeout. 10 * - Evaluating the output of each test as pass/fail/crash/timeout.
(...skipping 1446 matching lines...) Expand 10 before | Expand all | Expand 10 after
1457 field.write(c); 1457 field.write(c);
1458 } 1458 }
1459 result.add(field.toString()); 1459 result.add(field.toString());
1460 return result; 1460 return result;
1461 } 1461 }
1462 1462
1463 for (String line in decodeUtf8(super.stderr).split("\n")) { 1463 for (String line in decodeUtf8(super.stderr).split("\n")) {
1464 if (line.length == 0) continue; 1464 if (line.length == 0) continue;
1465 List<String> fields = splitMachineError(line); 1465 List<String> fields = splitMachineError(line);
1466 // We only consider errors/warnings for files of interest. 1466 // We only consider errors/warnings for files of interest.
1467 if (fields.length > FILENAME) { 1467 if (fields.length > FORMATTED_ERROR) {
1468 if (fields[ERROR_LEVEL] == 'ERROR') { 1468 if (fields[ERROR_LEVEL] == 'ERROR') {
1469 outErrors.add(fields[FORMATTED_ERROR]); 1469 outErrors.add(fields[FORMATTED_ERROR]);
1470 } else if (fields[ERROR_LEVEL] == 'WARNING') { 1470 } else if (fields[ERROR_LEVEL] == 'WARNING') {
1471 outWarnings.add(fields[FORMATTED_ERROR]); 1471 outWarnings.add(fields[FORMATTED_ERROR]);
1472 } 1472 }
1473 // OK to Skip error output that doesn't match the machine format 1473 // OK to Skip error output that doesn't match the machine format
1474 } 1474 }
1475 } 1475 }
1476 } 1476 }
1477 } 1477 }
(...skipping 1456 matching lines...) Expand 10 before | Expand all | Expand 10 after
2934 } 2934 }
2935 } 2935 }
2936 2936
2937 void eventAllTestsDone() { 2937 void eventAllTestsDone() {
2938 for (var listener in _eventListener) { 2938 for (var listener in _eventListener) {
2939 listener.allDone(); 2939 listener.allDone();
2940 } 2940 }
2941 _allDone(); 2941 _allDone();
2942 } 2942 }
2943 } 2943 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698