Enable header checking for chrome/browser/ui

Enable header checking for chrome/browser/ui

This disables header checking for split static libraries. In addition to the internal issues discussed in the added comment to split_static_library.gni, there is a circular include cycle between //chrome/browser and //chrome/browser/ui. Both of these are split static libraries, so enabling check for this configuration would additionally require listing all of the split ui targets in the allow_circular_includes_from annotation in the browser target.

Since this is only for official builds, we still get header checking on the normal builds so there should be no missing coverage for header checking.

R=dpranke@chromium.org

Committed: https://crrev.com/b3e6014f6994d0eb4abe1a60ca4ceb580f73ad9b
Cr-Commit-Position: refs/heads/master@{#420705}

[brettw, 2016-09-23 16:41:33]

.

[brettw, 2016-09-23 16:41:34]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 16:42:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dirk Pranke, 2016-09-23 17:46:06]

lgtm

[commit-bot: I haz the power, 2016-09-23 18:03:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 18:03:05]

Dry run: This issue passed the CQ dry run.

[brettw, 2016-09-23 19:48:35]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-09-23 19:49:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 19:55:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-23 19:57:46]

Description was changed from

==========
Enable header checking for chrome/browser/ui

This disables header checking for split static libraries. In addition to the
internal issues discussed in the added comment to split_static_library.gni,
there is a circular include cycle between //chrome/browser and
//chrome/browser/ui. Both of these are split static libraries, so enabling check
for this configuration would additionally require listing all of the split ui
targets in the allow_circular_includes_from annotation in the browser target.

Since this is only for official builds, we still get header checking on the
normal builds so there should be no missing coverage for header checking.

R=dpranke@chromium.org
==========

to

==========
Enable header checking for chrome/browser/ui

This disables header checking for split static libraries. In addition to the
internal issues discussed in the added comment to split_static_library.gni,
there is a circular include cycle between //chrome/browser and
//chrome/browser/ui. Both of these are split static libraries, so enabling check
for this configuration would additionally require listing all of the split ui
targets in the allow_circular_includes_from annotation in the browser target.

Since this is only for official builds, we still get header checking on the
normal builds so there should be no missing coverage for header checking.

R=dpranke@chromium.org

Committed: https://crrev.com/b3e6014f6994d0eb4abe1a60ca4ceb580f73ad9b
Cr-Commit-Position: refs/heads/master@{#420705}
==========

[commit-bot: I haz the power, 2016-09-23 19:57:47]

Patchset 2 (id:??) landed as
https://crrev.com/b3e6014f6994d0eb4abe1a60ca4ceb580f73ad9b
Cr-Commit-Position: refs/heads/master@{#420705}