Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: build/split_static_library.gni

Issue 2363083003: Enable header checking for chrome/browser/ui (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « .gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/split_static_library.gni
diff --git a/build/split_static_library.gni b/build/split_static_library.gni
index 5b7de52947c44971b12e38026b14e25bea753020..ea378e38dd7a789155e41353a96b4602ab08df0b 100644
--- a/build/split_static_library.gni
+++ b/build/split_static_library.gni
@@ -31,12 +31,23 @@ template("split_static_library") {
forward_variables_from(invoker,
"*",
[
+ "check_includes",
"sources",
"visibility",
])
sources = current_sources
visibility = [ ":$group_name" ]
+ # When splitting a target's sources up into a series of static
+ # libraries, those targets will naturally include headers from each
+ # other arbitrarily. We could theoretically generate a web of
+ # dependencies and allow_circular_includes_from between all pairs of
+ # targets, but that's very cumbersome. Typical usage in Chrome is that
+ # only official Windows builds use split static libraries due to the
+ # Visual Studio size limits, and this means we'll still get header
+ # checking coverage for the other configurations.
+ check_includes = false
+
# Uniquify the output name if one is specified.
if (defined(invoker.output_name)) {
output_name = "${invoker.output_name}_$current_library_index"
« no previous file with comments | « .gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698