Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 236303015: Remove some uses of MaybeObject methods. (Closed)

Created:
6 years, 8 months ago by Yang
Modified:
6 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Remove some uses of MaybeObject methods. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20786

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -105 lines) Patch
M src/isolate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects.h View 3 chunks +0 lines, -15 lines 0 comments Download
M src/objects-inl.h View 2 chunks +0 lines, -15 lines 0 comments Download
M src/runtime.cc View 6 chunks +45 lines, -53 lines 0 comments Download
M test/cctest/test-global-handles.cc View 3 chunks +20 lines, -20 lines 0 comments Download
M test/cctest/test-strings.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 8 months ago (2014-04-16 06:53:33 UTC) #1
Benedikt Meurer
LGTM
6 years, 8 months ago (2014-04-16 06:57:29 UTC) #2
Yang
6 years, 8 months ago (2014-04-16 07:27:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20786 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698