Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/isolate.cc

Issue 236303015: Remove some uses of MaybeObject methods. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 875 matching lines...) Expand 10 before | Expand all | Expand 10 after
886 Failure* Isolate::ReThrow(Object* exception) { 886 Failure* Isolate::ReThrow(Object* exception) {
887 bool can_be_caught_externally = false; 887 bool can_be_caught_externally = false;
888 bool catchable_by_javascript = is_catchable_by_javascript(exception); 888 bool catchable_by_javascript = is_catchable_by_javascript(exception);
889 ShouldReportException(&can_be_caught_externally, catchable_by_javascript); 889 ShouldReportException(&can_be_caught_externally, catchable_by_javascript);
890 890
891 thread_local_top()->catcher_ = can_be_caught_externally ? 891 thread_local_top()->catcher_ = can_be_caught_externally ?
892 try_catch_handler() : NULL; 892 try_catch_handler() : NULL;
893 893
894 // Set the exception being re-thrown. 894 // Set the exception being re-thrown.
895 set_pending_exception(exception); 895 set_pending_exception(exception);
896 if (exception->IsFailure()) return exception->ToFailureUnchecked();
897 return Failure::Exception(); 896 return Failure::Exception();
898 } 897 }
899 898
900 899
901 Failure* Isolate::ThrowIllegalOperation() { 900 Failure* Isolate::ThrowIllegalOperation() {
902 if (FLAG_stack_trace_on_illegal) PrintStack(stdout); 901 if (FLAG_stack_trace_on_illegal) PrintStack(stdout);
903 return Throw(heap_.illegal_access_string()); 902 return Throw(heap_.illegal_access_string());
904 } 903 }
905 904
906 905
(...skipping 1356 matching lines...) Expand 10 before | Expand all | Expand 10 after
2263 Handle<JSObject> obj = factory()->NewJSObjectFromMap(map); 2262 Handle<JSObject> obj = factory()->NewJSObjectFromMap(map);
2264 JSObject::NormalizeProperties(obj, KEEP_INOBJECT_PROPERTIES, 8); 2263 JSObject::NormalizeProperties(obj, KEEP_INOBJECT_PROPERTIES, 8);
2265 JSObject::SetProperty(registry, name, obj, NONE, STRICT).Assert(); 2264 JSObject::SetProperty(registry, name, obj, NONE, STRICT).Assert();
2266 } 2265 }
2267 } 2266 }
2268 return Handle<JSObject>::cast(factory()->symbol_registry()); 2267 return Handle<JSObject>::cast(factory()->symbol_registry());
2269 } 2268 }
2270 2269
2271 2270
2272 } } // namespace v8::internal 2271 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698