Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2362953002: Fix a timing bug in multibuffer. (Closed)

Created:
4 years, 3 months ago by hubbe
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Fix a timing bug in multibuffer. When "cancel on defer is on", the multibuffer reader can sometimes get delete before it is allowed to deliver a pending read callback. This basically hangs the multibuffer data source as it waits for the read callback forever. BUG=648395, 647867, 646434 Review-Url: https://codereview.chromium.org/2357773003 Cr-Commit-Position: refs/heads/master@{#419995} (cherry picked from commit 3b2a5629da155db59d3449a6d640c107e91aa14d) Committed: https://chromium.googlesource.com/chromium/src/+/b39d634c0efdd5912bfca4336ba9dc908e67fe10

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -7 lines) Patch
M media/blink/multibuffer_data_source.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/blink/multibuffer_data_source.cc View 3 chunks +9 lines, -5 lines 0 comments Download
M media/blink/multibuffer_data_source_unittest.cc View 3 chunks +35 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
hubbe
4 years, 3 months ago (2016-09-22 22:40:46 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b39d634c0efdd5912bfca4336ba9dc908e67fe10.

Powered by Google App Engine
This is Rietveld 408576698