Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: media/blink/multibuffer_data_source.h

Issue 2362953002: Fix a timing bug in multibuffer. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/blink/multibuffer_data_source.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/multibuffer_data_source.h
diff --git a/media/blink/multibuffer_data_source.h b/media/blink/multibuffer_data_source.h
index 5d3df792b0cc11e82c8148afa968998282128fce..eaaf94200655257856333634222260a0cc0a80f4 100644
--- a/media/blink/multibuffer_data_source.h
+++ b/media/blink/multibuffer_data_source.h
@@ -171,7 +171,8 @@ class MEDIA_BLINK_EXPORT MultibufferDataSource : public DataSource {
// call downloading_cb_ if needed.
// If |force_loading| is true, we call downloading_cb_ and tell it that
// we are currently loading, regardless of what reader_->IsLoading() says.
- void UpdateLoadingState(bool force_loading);
+ // Caller must hold |lock_|.
+ void UpdateLoadingState_Locked(bool force_loading);
// Update |reader_|'s preload and buffer settings.
void UpdateBufferSizes();
« no previous file with comments | « no previous file | media/blink/multibuffer_data_source.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698