Issue 23629031: Remove V8_WARN_UNUSED_RESULT for simple getters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23629031: Remove V8_WARN_UNUSED_RESULT for simple getters. (Closed)

Created:
7 years, 3 months ago by Michael Starzinger

Modified:
7 years, 3 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -16 lines)			Patch
M	src/cpu.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform/condition-variable.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/platform/elapsed-timer.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/platform/mutex.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/platform/semaphore.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/platform/socket.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 5 (0 generated)

Michael Starzinger

Ceterum censeo V8_WARN_UNUSED_RESULT esse delendam.

7 years, 3 months ago (2013-09-09 17:22:56 UTC) #1

Benedikt Meurer

On 2013/09/09 17:22:56, Michael Starzinger wrote: > Ceterum censeo V8_WARN_UNUSED_RESULT esse delendam. Out of curiousity, ...

7 years, 3 months ago (2013-09-10 05:55:58 UTC) #2

Michael Starzinger

On 2013/09/10 05:55:58, Benedikt Meurer wrote: > On 2013/09/09 17:22:56, Michael Starzinger wrote: > > ...

7 years, 3 months ago (2013-09-10 15:01:04 UTC) #4

Michael Starzinger

7 years, 3 months ago (2013-09-10 15:03:29 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r16624 (presubmit successful).