Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 23629031: Remove V8_WARN_UNUSED_RESULT for simple getters. (Closed)

Created:
7 years, 3 months ago by Michael Starzinger
Modified:
7 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Remove V8_WARN_UNUSED_RESULT for simple getters. R=bmeurer@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16624

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M src/cpu.h View 1 chunk +1 line, -1 line 0 comments Download
M src/platform/condition-variable.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/platform/elapsed-timer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/platform/mutex.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/platform/semaphore.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/platform/socket.h View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Starzinger
Ceterum censeo V8_WARN_UNUSED_RESULT esse delendam.
7 years, 3 months ago (2013-09-09 17:22:56 UTC) #1
Benedikt Meurer
On 2013/09/09 17:22:56, Michael Starzinger wrote: > Ceterum censeo V8_WARN_UNUSED_RESULT esse delendam. Out of curiousity, ...
7 years, 3 months ago (2013-09-10 05:55:58 UTC) #2
Benedikt Meurer
LGTM.
7 years, 3 months ago (2013-09-10 06:09:07 UTC) #3
Michael Starzinger
On 2013/09/10 05:55:58, Benedikt Meurer wrote: > On 2013/09/09 17:22:56, Michael Starzinger wrote: > > ...
7 years, 3 months ago (2013-09-10 15:01:04 UTC) #4
Michael Starzinger
7 years, 3 months ago (2013-09-10 15:03:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r16624 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698