Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: src/platform/socket.h

Issue 23629031: Remove V8_WARN_UNUSED_RESULT for simple getters. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/platform/semaphore.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/platform/socket.h
diff --git a/src/platform/socket.h b/src/platform/socket.h
index 6710692c544734cf882de92e13702686aed4e9e1..e9e2fa2eceb23395d8d348256ac20ad25a5aad8f 100644
--- a/src/platform/socket.h
+++ b/src/platform/socket.h
@@ -66,11 +66,11 @@ class Socket V8_FINAL {
// Set the value of the SO_REUSEADDR socket option.
bool SetReuseAddress(bool reuse_address);
- V8_INLINE(bool IsValid()) const V8_WARN_UNUSED_RESULT {
+ V8_INLINE(bool IsValid()) const {
return native_handle_ != kInvalidNativeHandle;
}
- static int GetLastError() V8_WARN_UNUSED_RESULT;
+ static int GetLastError();
// The implementation-defined native handle type.
#if V8_OS_POSIX
@@ -81,10 +81,10 @@ class Socket V8_FINAL {
static const NativeHandle kInvalidNativeHandle = INVALID_SOCKET;
#endif
- NativeHandle& native_handle() V8_WARN_UNUSED_RESULT {
+ NativeHandle& native_handle() {
return native_handle_;
}
- const NativeHandle& native_handle() const V8_WARN_UNUSED_RESULT {
+ const NativeHandle& native_handle() const {
return native_handle_;
}
« no previous file with comments | « src/platform/semaphore.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698