Add a hack to allow us to disable extension garbage collection.

Add a hack to allow us to disable extension garbage collection.
This allows us to disable extension garbage collection for the kiosk mode screensaver extension.

See associated bug for details.

R=asargent@chromium.org
BUG=280363
TEST=Screensaver plays through and loops in retail kiosk mode.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221366

[asargent_no_longer_on_chrome, 2013-09-04 23:09:01]

lgtm

https://codereview.chromium.org/23629027/diff/1/chrome/browser/chromeos/kiosk...
File chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc (right):

https://codereview.chromium.org/23629027/diff/1/chrome/browser/chromeos/kiosk...
chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc:109: // service
once this code is deprecated.
please add a link to the bug here

https://codereview.chromium.org/23629027/diff/1/chrome/browser/chromeos/kiosk...
chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc:172: // service
once this code is deprecated.
here too

https://codereview.chromium.org/23629027/diff/1/chrome/browser/extensions/ext...
File chrome/browser/extensions/extension_service.h (right):

https://codereview.chromium.org/23629027/diff/1/chrome/browser/extensions/ext...
chrome/browser/extensions/extension_service.h:976: // See crbug.com/263582
nit: is this the right bug id? The referenced bug doesn't seem related

[rkc, 2013-09-04 23:11:56]

https://codereview.chromium.org/23629027/diff/1/chrome/browser/chromeos/kiosk...
File chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc (right):

https://codereview.chromium.org/23629027/diff/1/chrome/browser/chromeos/kiosk...
chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc:109: // service
once this code is deprecated.
On 2013/09/04 23:09:01, Antony Sargent wrote:
> please add a link to the bug here

Done.

https://codereview.chromium.org/23629027/diff/1/chrome/browser/chromeos/kiosk...
chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc:172: // service
once this code is deprecated.
On 2013/09/04 23:09:01, Antony Sargent wrote:
> here too

Done.

https://codereview.chromium.org/23629027/diff/1/chrome/browser/extensions/ext...
File chrome/browser/extensions/extension_service.h (right):

https://codereview.chromium.org/23629027/diff/1/chrome/browser/extensions/ext...
chrome/browser/extensions/extension_service.h:976: // See crbug.com/263582
On 2013/09/04 23:09:01, Antony Sargent wrote:
> nit: is this the right bug id? The referenced bug doesn't seem related

Copy/paste derp. Fixed.
Done.

[commit-bot: I haz the power, 2013-09-04 23:14:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rkc@chromium.org/23629027/7001

[scherkus (not reviewing), 2013-09-04 23:24:11]

https://codereview.chromium.org/23629027/diff/7001/chrome/browser/extensions/...
File chrome/browser/extensions/extension_service.cc (right):

https://codereview.chromium.org/23629027/diff/7001/chrome/browser/extensions/...
chrome/browser/extensions/extension_service.cc:377:
disable_garbage_collection_(false) {
FYI this isn't covered by defined(OS_CHROMEOS)

[rkc, 2013-09-04 23:52:55]

https://codereview.chromium.org/23629027/diff/7001/chrome/browser/extensions/...
File chrome/browser/extensions/extension_service.cc (right):

https://codereview.chromium.org/23629027/diff/7001/chrome/browser/extensions/...
chrome/browser/extensions/extension_service.cc:377:
disable_garbage_collection_(false) {
On 2013/09/04 23:24:11, scherkus wrote:
> FYI this isn't covered by defined(OS_CHROMEOS)

Yep, causing the builds to fail. Fixed.

[commit-bot: I haz the power, 2013-09-04 23:54:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rkc@chromium.org/23629027/5001

[commit-bot: I haz the power, 2013-09-05 01:02:12]

Retried try job too often on ios_dbg_simulator for step(s) ui_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-09-05 06:59:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rkc@chromium.org/23629027/5001

[commit-bot: I haz the power, 2013-09-05 07:27:45]

Retried try job too often on ios_dbg_simulator for step(s) ui_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-09-05 08:19:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rkc@chromium.org/23629027/5001

[commit-bot: I haz the power, 2013-09-05 08:20:11]

Change committed as 221366