Add a hack to allow us to disable extension garbage collection.

chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.h"
 
 #include "ash/screensaver/screensaver_view.h"
 #include "ash/shell.h"
 #include "ash/wm/user_activity_detector.h"
 #include "base/bind.h"
@@ skipping 18 matching lines @@
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/notification_service.h"
 
 using extensions::Extension;
 using extensions::SandboxedUnpacker;
 
 namespace chromeos {
 
 namespace {
 
+ExtensionService* GetDefaultExtensionService() {
+  Profile* default_profile = ProfileManager::GetDefaultProfile();
+  if (!default_profile)
+    return NULL;
+  return extensions::ExtensionSystem::Get(
+      default_profile)->extension_service();
+}
+
 typedef base::Callback<void(
     scoped_refptr<Extension>,
     const base::FilePath&)> UnpackCallback;
 
 class ScreensaverUnpackerClient
     : public extensions::SandboxedUnpackerClient {
  public:
   ScreensaverUnpackerClient(const base::FilePath& crx_path,
                             const UnpackCallback& unpacker_callback)
       : crx_path_(crx_path),
@@ skipping 40 matching lines @@
 void ScreensaverUnpackerClient::OnUnpackFailure(const string16& error) {
   LOG(ERROR) << "Couldn't unpack screensaver extension. Error: " << error;
   NotifyAppPackOfDamagedFile();
 }
 
 void ScreensaverUnpackerClient::LoadScreensaverExtension(
     const base::FilePath& extension_base_path,
     const base::FilePath& screensaver_extension_path) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::FILE));
 
+  ExtensionService* service = GetDefaultExtensionService();
+  // TODO(rkc): This is a HACK, please remove this method from extension
+  // service once this code is deprecated.

[asargent_no_longer_on_chrome, 2013/09/04 23:09:01]

please add a link to the bug here

[rkc, 2013/09/04 23:11:56]

Done.

+  if (service)
+    service->disable_garbage_collection();
+
   std::string error;
   scoped_refptr<Extension> screensaver_extension =
       extension_file_util::LoadExtension(screensaver_extension_path,
                                          extensions::Manifest::COMPONENT,
                                          Extension::NO_FLAGS,
                                          &error);
   if (!screensaver_extension.get()) {
     LOG(ERROR) << "Could not load screensaver extension from: "
                << screensaver_extension_path.value() << " due to: " << error;
     NotifyAppPackOfDamagedFile();
@@ skipping 37 matching lines @@
   } else {
     kiosk_mode_settings->Initialize(base::Bind(
         &KioskModeScreensaver::GetScreensaverCrxPath,
         weak_ptr_factory_.GetWeakPtr()));
   }
 }
 
 KioskModeScreensaver::~KioskModeScreensaver() {
   // If the extension was unpacked.
   if (!extension_base_path_.empty()) {
+    ExtensionService* service = GetDefaultExtensionService();
+    // TODO(rkc): This is a HACK, please remove this method from extension
+    // service once this code is deprecated.

[asargent_no_longer_on_chrome, 2013/09/04 23:09:01]

here too

[rkc, 2013/09/04 23:11:56]

Done.

+    if (service)
+      service->enable_garbage_collection();
+
     // Delete it.
     content::BrowserThread::PostTask(
         content::BrowserThread::FILE,
         FROM_HERE,
         base::Bind(
             &extension_file_util::DeleteFile, extension_base_path_, true));
   }
 
   // In case we're shutting down without ever triggering the active
   // notification and/or logging in.
@@ skipping 10 matching lines @@
 }
 
 void KioskModeScreensaver::ScreensaverPathCallback(
     const base::FilePath& screensaver_crx) {
   if (screensaver_crx.empty())
     return;
 
   Profile* default_profile = ProfileManager::GetDefaultProfile();
   if (!default_profile)
     return;
-  base::FilePath extensions_dir = extensions::ExtensionSystem::Get(
-      default_profile)->extension_service()->install_directory();
+  base::FilePath extensions_dir =
+      GetDefaultExtensionService()->install_directory();
   scoped_refptr<SandboxedUnpacker> screensaver_unpacker(
       new SandboxedUnpacker(
           screensaver_crx,
           extensions::Manifest::COMPONENT,
           Extension::NO_FLAGS,
           extensions_dir,
           content::BrowserThread::GetMessageLoopProxyForThread(
               content::BrowserThread::FILE).get(),
           new ScreensaverUnpackerClient(
               screensaver_crx,
@@ skipping 77 matching lines @@
 
   g_kiosk_mode_screensaver = new KioskModeScreensaver();
 }
 
 void ShutdownKioskModeScreensaver() {
   delete g_kiosk_mode_screensaver;
   g_kiosk_mode_screensaver = NULL;
 }
 
 }  // namespace chromeos