Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 2362853003: Revert of [turbofan] Don't take into account source size for inlining heuristics. (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Don't take into account source size for inlining heuristics. (patchset #4 id:60001 of https://codereview.chromium.org/2361813002/ ) Reason for revert: timeouts on windows: https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20debug/builds/12504 Original issue's description: > [turbofan] Don't take into account source size for inlining heuristics. > > The source size is not a real indicator for whether or not to inline a > certain function. > > R=ishell@chromium.org, jarin@chromium.org > BUG=v8:3354, v8:5267 > > Committed: https://chromium.googlesource.com/v8/v8/+/1b33028607637ba8cb2d60433811f825b00a0cc1 TBR=ishell@chromium.org,jarin@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3354, v8:5267 Committed: https://crrev.com/99160dc1c124d39c5d9e1eeb14bb363ab554ce6c Cr-Commit-Position: refs/heads/master@{#39661}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M src/compiler/js-inlining-heuristic.cc View 2 chunks +8 lines, -1 line 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/es6/tail-call-megatest.js View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [turbofan] Don't take into account source size for inlining heuristics.
4 years, 3 months ago (2016-09-23 12:42:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2362853003/1
4 years, 3 months ago (2016-09-23 12:43:12 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 12:43:29 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 12:43:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/99160dc1c124d39c5d9e1eeb14bb363ab554ce6c
Cr-Commit-Position: refs/heads/master@{#39661}

Powered by Google App Engine
This is Rietveld 408576698