Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2361813002: [turbofan] Don't take into account source size for inlining heuristics. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Don't take into account source size for inlining heuristics. The source size is not a real indicator for whether or not to inline a certain function. R=ishell@chromium.org, jarin@chromium.org BUG=v8:3354, v8:5267 Committed: https://chromium.googlesource.com/v8/v8/+/1b33028607637ba8cb2d60433811f825b00a0cc1 Committed: https://crrev.com/0702ea3000df8235c8bfcf1e99a948ba38964ee3 Cr-Commit-Position: refs/heads/master@{#39681}

Patch Set 1 #

Patch Set 2 : Fix word32 vs word64 bug uncovered in CodeStubAssembler::UpdateFeedback by this change. #

Patch Set 3 : Also handle appropriate baselining for test case. #

Patch Set 4 : REBASE on bugfix. #

Patch Set 5 : Mozilla timeouts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M src/compiler/js-inlining-heuristic.cc View 2 chunks +1 line, -8 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/es6/tail-call-megatest.js View 1 chunk +4 lines, -3 lines 0 comments Download
M test/mozilla/mozilla.status View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 45 (31 generated)
Benedikt Meurer
4 years, 3 months ago (2016-09-22 10:50:02 UTC) #1
Jarin
lgtm
4 years, 3 months ago (2016-09-22 10:52:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361813002/1
4 years, 3 months ago (2016-09-22 10:58:46 UTC) #7
Igor Sheludko
lgtm
4 years, 3 months ago (2016-09-22 11:01:41 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/builds/9042) v8_linux_arm64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 3 months ago (2016-09-22 11:41:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361813002/20001
4 years, 3 months ago (2016-09-23 04:33:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361813002/40001
4 years, 3 months ago (2016-09-23 04:38:28 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/13312) v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 3 months ago (2016-09-23 05:04:29 UTC) #19
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/1b33028607637ba8cb2d60433811f825b00a0cc1 Cr-Commit-Position: refs/heads/master@{#39659}
4 years, 3 months ago (2016-09-23 11:47:26 UTC) #30
Benedikt Meurer
Committed patchset #4 (id:60001) manually as 1b33028607637ba8cb2d60433811f825b00a0cc1 (presubmit successful).
4 years, 3 months ago (2016-09-23 11:47:30 UTC) #32
Michael Achenbach
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/2362853003/ by machenbach@chromium.org. ...
4 years, 3 months ago (2016-09-23 12:42:54 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361813002/100001
4 years, 3 months ago (2016-09-23 16:20:41 UTC) #41
commit-bot: I haz the power
Committed patchset #5 (id:100001)
4 years, 3 months ago (2016-09-23 16:23:25 UTC) #43
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 16:23:48 UTC) #45
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/0702ea3000df8235c8bfcf1e99a948ba38964ee3
Cr-Commit-Position: refs/heads/master@{#39681}

Powered by Google App Engine
This is Rietveld 408576698