Fix use uninitialized value and stack buffer overflow read

Fix use uninitialized value and stack buffer overflow read

Found by libfuzzer

Committed: https://pdfium.googlesource.com/pdfium/+/62356867b331bc9f71f9a0c8fce0cff9927d3356

[kcwu, 2016-09-22 19:02:55]

kcwu@chromium.org changed reviewers:
+ tsepez@chromium.org

[kcwu, 2016-09-22 19:02:56]

PTAL

[Tom Sepez, 2016-09-22 19:24:45]

LGTM with nit.

https://codereview.chromium.org/2362813002/diff/1/third_party/lcms2-2.6/src/c...
File third_party/lcms2-2.6/src/cmstypes.c (right):

https://codereview.chromium.org/2362813002/diff/1/third_party/lcms2-2.6/src/c...
third_party/lcms2-2.6/src/cmstypes.c:2967: char Name[34];
nit: can we make this Name[33] to avoid questions about what the additional byte
beyond the NUL is for?

[kcwu, 2016-09-22 19:31:43]

https://codereview.chromium.org/2362813002/diff/1/third_party/lcms2-2.6/src/c...
File third_party/lcms2-2.6/src/cmstypes.c (right):

https://codereview.chromium.org/2362813002/diff/1/third_party/lcms2-2.6/src/c...
third_party/lcms2-2.6/src/cmstypes.c:2967: char Name[34];
On 2016/09/22 19:24:45, Tom Sepez wrote:
> nit: can we make this Name[33] to avoid questions about what the additional
byte
> beyond the NUL is for?

Done.

[kcwu, 2016-09-22 19:42:43]

The CQ bit was checked by kcwu@chromium.org

[kcwu, 2016-09-22 19:42:43]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2362813002/#ps20001
(title: "address tsepez's comments")

[commit-bot: I haz the power, 2016-09-22 19:42:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 19:56:25]

Description was changed from

==========
Fix use uninitialized value and stack buffer overflow read

Found by libfuzzer
==========

to

==========
Fix use uninitialized value and stack buffer overflow read

Found by libfuzzer

Committed:
https://pdfium.googlesource.com/pdfium/+/62356867b331bc9f71f9a0c8fce0cff9927d...
==========

[commit-bot: I haz the power, 2016-09-22 19:56:25]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/62356867b331bc9f71f9a0c8fce0cff9927d...