third_party/lcms2-2.6/0003-uninit.patch - Issue 2362813002: Fix use uninitialized value and stack buffer overflow read

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/lcms2-2.6/0003-uninit.patch

Issue 2362813002: Fix use uninitialized value and stack buffer overflow read (Closed)

Patch Set: address tsepez's comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 diff --git a/third_party/lcms2-2.6/src/cmstypes.c b/third_party/lcms2-2.6/src/cm stypes.c

	2 index 06742b5..44c5b87 100644

	3 --- a/third_party/lcms2-2.6/src/cmstypes.c

	4 +++ b/third_party/lcms2-2.6/src/cmstypes.c

	5 @@ -2964,7 +2964,7 @@ void Type_ColorantTable_Read(struct _cms_typehandler_stru ct self, cmsIOHANDLER

	6 {

	7 cmsUInt32Number i, Count;

	8 cmsNAMEDCOLORLIST* List;

	9 - char Name[34];

	10 + char Name[33];

	11 cmsUInt16Number PCS[3];

	12

	13

	14 @@ -2979,7 +2979,7 @@ void Type_ColorantTable_Read(struct _cms_typehandler_stru ct self, cmsIOHANDLER

	15 for (i=0; i < Count; i++) {

	16

	17 if (io ->Read(io, Name, 32, 1) != 1) goto Error;

	18 - Name[33] = 0;

	19 + Name[32] = 0;

	20

	21 if (!_cmsReadUInt16Array(io, 3, PCS)) goto Error;

	22

	23 @@ -3106,6 +3106,7 @@ void Type_NamedColor_Read(struct _cms_typehandler_struct self, cmsIOHANDLER* i

	24

	25 memset(Colorant, 0, sizeof(Colorant));

	26 if (io -> Read(io, Root, 32, 1) != 1) return NULL;

	27 + Root[32] = 0;

	28 if (!_cmsReadUInt16Array(io, 3, PCS)) goto Error;

	29 if (!_cmsReadUInt16Array(io, nDeviceCoords, Colorant)) goto Error;

	30

OLD	NEW

« no previous file with comments | « no previous file | third_party/lcms2-2.6/README.pdfium » ('j') | no next file with comments »