chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.html - Issue 2362673004: Aligns text to braille in chromevox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.html

Issue 2362673004: Aligns text to braille in chromevox. (Closed)

Patch Set: Addressed code reviews. Extracted grouping algorithm into a helper method. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/chromeos/chromevox/chromevox/background/braille_captions_background.js ('K') | « chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.css ('k') | chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.html

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.html b/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.html

index e2ff9330476a393d7f8b9538c7e3420a9aa8214d..9656c74327c633f922e141d1b0d2843d4c3dd48a 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.html

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.html

@@ -31,8 +31,10 @@

</div>

- <div id="braille-text"></div>

- <div id="braille-cells"></div>

+ <table id="braille-table">

+ <tr></tr><tr></tr>

+ </table>

+ </div>

dmazzoni 2016/09/29 16:13:13 nit: it looks like you have an extra </div> here

ultimatedbz 2016/09/29 21:00:55 Done.

</div>