Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.html

Issue 2362673004: Aligns text to braille in chromevox. (Closed)
Patch Set: Addressed code reviews. Extracted grouping algorithm into a helper method. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <!-- Copyright 2015 The Chromium Authors. All rights reserved. 1 <!-- Copyright 2015 The Chromium Authors. All rights reserved.
2 Use of this source code is governed by a BSD-style license that can be 2 Use of this source code is governed by a BSD-style license that can be
3 found in the LICENSE file. --> 3 found in the LICENSE file. -->
4 <html> 4 <html>
5 <head> 5 <head>
6 <meta charset="utf-8"> 6 <meta charset="utf-8">
7 <title class="i18n" msgid="panel_title"></title> 7 <title class="i18n" msgid="panel_title"></title>
8 8
9 <link href="http://fonts.googleapis.com/css?family=Droid+Sans+Mono|Roboto:400,70 0,700italic" rel="stylesheet" type="text/css"> 9 <link href="http://fonts.googleapis.com/css?family=Droid+Sans+Mono|Roboto:400,70 0,700italic" rel="stylesheet" type="text/css">
10 <link href="panel.css" rel="stylesheet" type="text/css"> 10 <link href="panel.css" rel="stylesheet" type="text/css">
(...skipping 13 matching lines...) Expand all
24 <div hidden id="menus_title" class="i18n" msgid="menus_title"></div> 24 <div hidden id="menus_title" class="i18n" msgid="menus_title"></div>
25 <button id="menus_button" aria-labelledby="menus_title"> 25 <button id="menus_button" aria-labelledby="menus_title">
26 <img id="chromevox" src="/images/chromevox-19.png"> 26 <img id="chromevox" src="/images/chromevox-19.png">
27 <img id="triangle" src="/images/triangle-6.png"> 27 <img id="triangle" src="/images/triangle-6.png">
28 </button> 28 </button>
29 <div id="caption"> 29 <div id="caption">
30 <div id="speech-container"> 30 <div id="speech-container">
31 <div id="speech"></div> 31 <div id="speech"></div>
32 </div> 32 </div>
33 <div id="braille-container"> 33 <div id="braille-container">
34 <div id="braille-text"></div> 34 <table id="braille-table">
35 <div id="braille-cells"></div> 35 <tr></tr><tr></tr>
36 </table>
37 </div>
dmazzoni 2016/09/29 16:13:13 nit: it looks like you have an extra </div> here
ultimatedbz 2016/09/29 21:00:55 Done.
36 </div> 38 </div>
37 <div id="search-container"> 39 <div id="search-container">
38 <input class="i18n" msgid="search_widget_intro" id="search" type="search"> </input> 40 <input class="i18n" msgid="search_widget_intro" id="search" type="search"> </input>
39 </div> 41 </div>
40 </div> 42 </div>
41 <div id="options_close"> 43 <div id="options_close">
42 <div hidden id="options_title" class="i18n" msgid="options"></div> 44 <div hidden id="options_title" class="i18n" msgid="options"></div>
43 <button id="options" aria-labelledby="options_title"></button> 45 <button id="options" aria-labelledby="options_title"></button>
44 <div hidden id="disable_chromevox_title" class="i18n" 46 <div hidden id="disable_chromevox_title" class="i18n"
45 msgid="disable_chromevox"></div> 47 msgid="disable_chromevox"></div>
(...skipping 10 matching lines...) Expand all
56 <button id="close_tutorial" aria-labelledby="close_tutorial_title"></button> 58 <button id="close_tutorial" aria-labelledby="close_tutorial_title"></button>
57 <div id="tutorial_main"> 59 <div id="tutorial_main">
58 </div> 60 </div>
59 <div id="tutorial_footer"> 61 <div id="tutorial_footer">
60 <button id="tutorial_previous" class="i18n" msgid="tutorial_previous"></butt on> 62 <button id="tutorial_previous" class="i18n" msgid="tutorial_previous"></butt on>
61 <button id="tutorial_next" class="i18n" msgid="tutorial_next"></button> 63 <button id="tutorial_next" class="i18n" msgid="tutorial_next"></button>
62 </div> 64 </div>
63 </div> 65 </div>
64 </body> 66 </body>
65 </html> 67 </html>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698