Add fuzzer for icc codec

Add fuzzer for icc codec

Committed: https://pdfium.googlesource.com/pdfium/+/da4bd1099d3566bc7f68a036eef091b07a8d873a

[kcwu, 2016-09-22 06:49:41]

kcwu@chromium.org changed reviewers:
+ tsepez@chromium.org

[Tom Sepez, 2016-09-22 16:46:49]

LGTM with nits.

https://codereview.chromium.org/2362623002/diff/1/testing/libfuzzer/pdf_codec...
File testing/libfuzzer/pdf_codec_icc_fuzzer.cc (right):

https://codereview.chromium.org/2362623002/diff/1/testing/libfuzzer/pdf_codec...
testing/libfuzzer/pdf_codec_icc_fuzzer.cc:17: for (int i = 0; i < nComponent;
i++)
Nit:  we could just set all 4 to 0.5, that way if somehow we got back N > 4,
asan would trip inside the translate call, rather than in this driver.

https://codereview.chromium.org/2362623002/diff/1/testing/libfuzzer/pdf_codec...
testing/libfuzzer/pdf_codec_icc_fuzzer.cc:18: src[i] = 0.5;
nit: If I were really picky, I'd say 0.5f, but as you like.

https://codereview.chromium.org/2362623002/diff/1/testing/libfuzzer/pdf_codec...
testing/libfuzzer/pdf_codec_icc_fuzzer.cc:23:
icc_module.DestroyTransform(transform);
nit: maybe we save a few cycles per test case if this moves inside the if
(transform) { block.

[kcwu, 2016-09-22 17:13:51]

https://codereview.chromium.org/2362623002/diff/1/testing/libfuzzer/pdf_codec...
File testing/libfuzzer/pdf_codec_icc_fuzzer.cc (right):

https://codereview.chromium.org/2362623002/diff/1/testing/libfuzzer/pdf_codec...
testing/libfuzzer/pdf_codec_icc_fuzzer.cc:17: for (int i = 0; i < nComponent;
i++)
On 2016/09/22 16:46:48, Tom Sepez wrote:
> Nit:  we could just set all 4 to 0.5, that way if somehow we got back N > 4,
> asan would trip inside the translate call, rather than in this driver.

Done.

https://codereview.chromium.org/2362623002/diff/1/testing/libfuzzer/pdf_codec...
testing/libfuzzer/pdf_codec_icc_fuzzer.cc:18: src[i] = 0.5;
On 2016/09/22 16:46:48, Tom Sepez wrote:
> nit: If I were really picky, I'd say 0.5f, but as you like.

Done.

https://codereview.chromium.org/2362623002/diff/1/testing/libfuzzer/pdf_codec...
testing/libfuzzer/pdf_codec_icc_fuzzer.cc:23:
icc_module.DestroyTransform(transform);
On 2016/09/22 16:46:48, Tom Sepez wrote:
> nit: maybe we save a few cycles per test case if this moves inside the if
> (transform) { block.

Done.

[kcwu, 2016-09-22 17:19:22]

The CQ bit was checked by kcwu@chromium.org

[kcwu, 2016-09-22 17:19:22]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2362623002/#ps20001
(title: "address tsepez's comments")

[commit-bot: I haz the power, 2016-09-22 17:19:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 17:30:21]

Description was changed from

==========
Add fuzzer for icc codec
==========

to

==========
Add fuzzer for icc codec

Committed:
https://pdfium.googlesource.com/pdfium/+/da4bd1099d3566bc7f68a036eef091b07a8d...
==========

[commit-bot: I haz the power, 2016-09-22 17:30:22]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/da4bd1099d3566bc7f68a036eef091b07a8d...