Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Issue 2362573002: Move Zone's destructor out of a header file. (Closed)

Created:
4 years, 3 months ago by rmacnak
Modified:
4 years, 3 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move Zone's destructor out of a header file. This unburdens users of StackZone from needing to include handles_impl.h. A new use of StackZone was recently added to heap.cc without a include of handles_impl.h, and this caused link-time errors on some versions of gcc. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/326af5e9d7de8863ab4141a42f8dd8513d8f408c

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -45 lines) Patch
M runtime/vm/intermediate_language.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/megamorphic_cache_table.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/native_arguments.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/profiler_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/symbols.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/zone.h View 1 2 chunks +4 lines, -40 lines 0 comments Download
M runtime/vm/zone.cc View 1 2 chunks +46 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 3 months ago (2016-09-22 00:40:37 UTC) #2
siva
lgtm
4 years, 3 months ago (2016-09-22 19:33:18 UTC) #3
rmacnak
4 years, 3 months ago (2016-09-22 20:16:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
326af5e9d7de8863ab4141a42f8dd8513d8f408c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698