Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: runtime/vm/zone.h

Issue 2362573002: Move Zone's destructor out of a header file. (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/symbols.cc ('k') | runtime/vm/zone.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/zone.h
diff --git a/runtime/vm/zone.h b/runtime/vm/zone.h
index 29d2765ba8ab68421eb984c5c1734750156bdbdf..57a584242898fdf980f22bb9673bbb3acfaa2b80 100644
--- a/runtime/vm/zone.h
+++ b/runtime/vm/zone.h
@@ -71,28 +71,8 @@ class Zone {
void VisitObjectPointers(ObjectPointerVisitor* visitor);
private:
- Zone()
- : initial_buffer_(buffer_, kInitialChunkSize),
- position_(initial_buffer_.start()),
- limit_(initial_buffer_.end()),
- head_(NULL),
- large_segments_(NULL),
- handles_(),
- previous_(NULL) {
- ASSERT(Utils::IsAligned(position_, kAlignment));
-#ifdef DEBUG
- // Zap the entire initial buffer.
- memset(initial_buffer_.pointer(), kZapUninitializedByte,
- initial_buffer_.size());
-#endif
- }
-
- ~Zone() { // Delete all memory associated with the zone.
- if (FLAG_trace_zones) {
- DumpZoneSizes();
- }
- DeleteAll();
- }
+ Zone();
+ ~Zone(); // Delete all memory associated with the zone.
// All pointers returned from AllocateUnsafe() and New() have this alignment.
static const intptr_t kAlignment = kDoubleSize;
@@ -185,26 +165,10 @@ class Zone {
class StackZone : public StackResource {
public:
// Create an empty zone and set is at the current zone for the Thread.
- explicit StackZone(Thread* thread) : StackResource(thread), zone_() {
- if (FLAG_trace_zones) {
- OS::PrintErr("*** Starting a new Stack zone 0x%" Px "(0x%" Px ")\n",
- reinterpret_cast<intptr_t>(this),
- reinterpret_cast<intptr_t>(&zone_));
- }
- zone_.Link(thread->zone());
- thread->set_zone(&zone_);
- }
+ explicit StackZone(Thread* thread);
// Delete all memory associated with the zone.
- ~StackZone() {
- ASSERT(thread()->zone() == &zone_);
- thread()->set_zone(zone_.previous_);
- if (FLAG_trace_zones) {
- OS::PrintErr("*** Deleting Stack zone 0x%" Px "(0x%" Px ")\n",
- reinterpret_cast<intptr_t>(this),
- reinterpret_cast<intptr_t>(&zone_));
- }
- }
+ ~StackZone();
// Compute the total size of this zone. This includes wasted space that is
// due to internal fragmentation in the segments.
« no previous file with comments | « runtime/vm/symbols.cc ('k') | runtime/vm/zone.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698