Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2362483002: Links to the newui preserve state (Closed)

Created:
4 years, 3 months ago by kjlubick
Modified:
4 years, 3 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, rmistry
Base URL:
git@github.com:luci/luci-py@nicer-botlist
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Links to the newui preserve state e.g. links now keep dimensions/tags and botid/taskid BUG=631047 Committed: https://github.com/luci/luci-py/commit/77eed20ab24dc41e693200f41d54479e9c3c0781

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M appengine/swarming/handlers_frontend.py View 6 chunks +11 lines, -0 lines 0 comments Download
M appengine/swarming/templates/restricted_bot.html View 1 chunk +2 lines, -0 lines 0 comments Download
M appengine/swarming/templates/restricted_botslist.html View 1 chunk +1 line, -1 line 0 comments Download
M appengine/swarming/templates/user_task.html View 1 chunk +2 lines, -0 lines 0 comments Download
M appengine/swarming/templates/user_tasks.html View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (3 generated)
kjlubick
4 years, 3 months ago (2016-09-21 20:06:37 UTC) #2
M-A Ruel
lgtm
4 years, 3 months ago (2016-09-21 20:17:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2362483002/1
4 years, 3 months ago (2016-09-22 11:30:57 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 11:34:45 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/77eed20ab24dc41e693200f41d54479e9c3c0781

Powered by Google App Engine
This is Rietveld 408576698