Declare the arguments object before creating the function var, to make sure it masks it

Declare the arguments object before creating the function var, to make sure it masks it

BUG=chromium:649067
Committed: https://crrev.com/df7ecd1c1a8acb6a8230b7a3524aef2d60803f14
Cr-Commit-Position: refs/heads/master@{#39642}

[Toon Verwaest, 2016-09-22 12:51:33]

verwaest@chromium.org changed reviewers:
+ nikolaos@chromium.org

[Toon Verwaest, 2016-09-22 12:51:34]

ptal

[Toon Verwaest, 2016-09-22 13:19:47]

Description was changed from

==========
Declare the arguments object before creating the function var, to make sure it
masks it

BUG=chromium:649067
==========

to

==========
Declare the arguments object before creating the function var, to make sure it
masks it

BUG=chromium:649067
==========

[Toon Verwaest, 2016-09-22 13:19:54]

cc adamk

[nickie, 2016-09-22 13:20:16]

It LGTM but I don't understand the details so it would be nice if somebody who
understands this better could take a look.

And, there seems to be something funny with the patch set, as the test file
seems to modify some other, existing file.

[Toon Verwaest, 2016-09-22 17:25:59]

The CQ bit was checked by verwaest@chromium.org

[commit-bot: I haz the power, 2016-09-22 17:26:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 17:30:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 17:30:54]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/24767)

[adamk, 2016-09-22 18:16:56]

adamk@chromium.org changed reviewers:
+ adamk@chromium.org

[adamk, 2016-09-22 18:16:57]

lgtm

https://codereview.chromium.org/2362463003/diff/1/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/2362463003/diff/1/src/parsing/parser.cc#newco...
src/parsing/parser.cc:3434:
function_scope->DeclareArguments(ast_value_factory());
Please add a comment here about why this must be declared this late.

[adamk, 2016-09-22 18:46:26]

lgtm

[Toon Verwaest, 2016-09-22 18:46:39]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2016-09-22 18:46:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
nikolaos@chromium.org
Link to the patchset: https://codereview.chromium.org/2362463003/#ps20001
(title: "Add comment")

[commit-bot: I haz the power, 2016-09-22 18:46:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 19:16:29]

Description was changed from

==========
Declare the arguments object before creating the function var, to make sure it
masks it

BUG=chromium:649067
==========

to

==========
Declare the arguments object before creating the function var, to make sure it
masks it

BUG=chromium:649067
==========

[commit-bot: I haz the power, 2016-09-22 19:16:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-22 19:16:55]

Description was changed from

==========
Declare the arguments object before creating the function var, to make sure it
masks it

BUG=chromium:649067
==========

to

==========
Declare the arguments object before creating the function var, to make sure it
masks it

BUG=chromium:649067

Committed: https://crrev.com/df7ecd1c1a8acb6a8230b7a3524aef2d60803f14
Cr-Commit-Position: refs/heads/master@{#39642}
==========

[commit-bot: I haz the power, 2016-09-22 19:16:56]

Patchset 2 (id:??) landed as
https://crrev.com/df7ecd1c1a8acb6a8230b7a3524aef2d60803f14
Cr-Commit-Position: refs/heads/master@{#39642}

[lpy, 2016-09-22 20:15:19]

Description was changed from

==========
Declare the arguments object before creating the function var, to make sure it
masks it

BUG=chromium:649067

Committed: https://crrev.com/df7ecd1c1a8acb6a8230b7a3524aef2d60803f14
Cr-Commit-Position: refs/heads/master@{#39642}
==========

to

==========
Declare the arguments object before creating the function var, to make sure it
masks it

BUG=chromium:649067

Committed: https://crrev.com/df7ecd1c1a8acb6a8230b7a3524aef2d60803f14
Cr-Commit-Position: refs/heads/master@{#39642}
==========