src/ast/scopes.cc - Issue 2362463003: Declare the arguments object before creating the function var, to make sure it masks it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast/scopes.cc

Issue 2362463003: Declare the arguments object before creating the function var, to make sure it masks it (Closed)

Patch Set: Add comment Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ast/scopes.cc

diff --git a/src/ast/scopes.cc b/src/ast/scopes.cc

index 109044521c9ef6552ecafc3c22184ed523a0c55a..9c5395a0c32f8d0cf60cbdef436704398e803d03 100644

--- a/src/ast/scopes.cc

+++ b/src/ast/scopes.cc

@@ -1218,7 +1218,6 @@ void DeclarationScope::AnalyzePartially(DeclarationScope* migrate_to,

DCHECK_EQ(outer_scope_->zone(), migrate_to->zone());

DCHECK_EQ(NeedsHomeObject(), migrate_to->NeedsHomeObject());

DCHECK_EQ(asm_function_, migrate_to->asm_function_);

- DCHECK_EQ(arguments() != nullptr, migrate_to->arguments() != nullptr);

}

#ifdef DEBUG

« no previous file with comments | « no previous file | src/parsing/parser.cc » ('j') | no next file with comments »